Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- test_current.rb: 2.8 -> 3.0 #731

Merged
merged 1 commit into from Sep 1, 2020
Merged

- test_current.rb: 2.8 -> 3.0 #731

merged 1 commit into from Sep 1, 2020

Conversation

@palkan
Copy link
Contributor

@palkan palkan commented Sep 1, 2020

Follow-up for #729

@koic
koic approved these changes Sep 1, 2020
Copy link
Collaborator

@koic koic left a comment

👍

@palkan
Copy link
Contributor Author

@palkan palkan commented Sep 1, 2020

@iliabylich Maybe, we shouldn't allow failures for ruby-head?

Another idea is to migrate to Github Actions and see separate statuses for different versions in PRs. And GA will likely be faster than Travis.

I have a working configuration here which could be ported to this repo.

@iliabylich
Copy link
Collaborator

@iliabylich iliabylich commented Sep 1, 2020

Maybe, we shouldn't allow failures for ruby-head?

Development branch of any repo on GH can be broken anytime. It shouldn't block us.

migrate to Github Actions and see separate statuses

I look at ruby-head/rubocop statuses only when I cut a release or if I feel that PR has some potentially breaking changes. Otherwise it's useless (again, because both can be broken)

And GA will likely be faster than Travis

I think it's fast enough. truffleruby is slow, but MRI tests take 1.5 minutes to run. Is truffleruby faster on GH actions? 👍 if so

@palkan
Copy link
Contributor Author

@palkan palkan commented Sep 1, 2020

Is truffleruby faster on GH actions?

Looks like slow is not the only problem 😀 Fatal error: java.lang.OutOfMemoryError https://travis-ci.org/github/whitequark/parser/jobs/723110359

Currently, I do not test against Truffle. I will check.

@iliabylich
Copy link
Collaborator

@iliabylich iliabylich commented Sep 1, 2020

I've restarted the job and now it's green (this is the 2nd failure that I've seen so far).

There are a few more changes that should be done, I'll make them in a separate PR.

Thanks, merging!

@iliabylich iliabylich merged commit 73b1945 into whitequark:master Sep 1, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@palkan palkan deleted the palkan:patch-1 branch Sep 1, 2020
@palkan
Copy link
Contributor Author

@palkan palkan commented Sep 1, 2020

Is truffleruby faster on GH actions?

~7-8 minutes: https://github.com/ruby-next/parser/runs/1057046471

I will try to provide a PR a bit later.

@iliabylich
Copy link
Collaborator

@iliabylich iliabylich commented Sep 1, 2020

Ok, let's try it. Do you want to send a PR?

@palkan
Copy link
Contributor Author

@palkan palkan commented Sep 1, 2020

Do you want to send a PR?

Yeah, I will try to do that tomorrow.

@palkan palkan mentioned this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.