Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure GitHub Actions #733

Merged
merged 1 commit into from Sep 2, 2020
Merged

Conversation

@palkan
Copy link
Contributor

@palkan palkan commented Sep 2, 2020

See discussion in #731

@palkan
Copy link
Contributor Author

@palkan palkan commented Sep 2, 2020

@iliabylich
Copy link
Collaborator

@iliabylich iliabylich commented Sep 2, 2020

I don't see any options on the Actions tab. Also, what you said should be configured on the fork repo:

Workflows don't run on forked repositories by default. You must enable GitHub Actions in the Actions tab of the forked repository

I guess I could try committing these changes manually to master. Are you ok with it?

Also, which config is used when someone submits a PR that changes a workflow config?

@palkan
Copy link
Contributor Author

@palkan palkan commented Sep 2, 2020

I guess I could try committing these changes manually to master. Are you ok with it?

Sure. Try to open PR, usually that works when you're a collaborator.

which config is used when someone submits a PR that changes a workflow config?

The one from the PR.

iliabylich added a commit to iliabylich/parser that referenced this pull request Sep 2, 2020
@iliabylich
Copy link
Collaborator

@iliabylich iliabylich commented Sep 2, 2020

#734 doesn't trigger GH action. Let's just merge this PR then

@iliabylich iliabylich marked this pull request as ready for review Sep 2, 2020
@iliabylich iliabylich merged commit bfeaa8b into whitequark:master Sep 2, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@palkan palkan deleted the ruby-next:chore/github-actions branch Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.