Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved truffleruby to allow_failures group in travis.yml #735

Merged

Conversation

@iliabylich
Copy link
Collaborator

@iliabylich iliabylich commented Sep 2, 2020

No description provided.

@iliabylich iliabylich merged commit 2f226a3 into whitequark:master Sep 2, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@iliabylich iliabylich deleted the iliabylich:move-truffleruby-to-allow-failures branch Sep 2, 2020
@eregon
Copy link

@eregon eregon commented Sep 16, 2020

Sorry about that, I will try to investigate why we run in a fatal OutOfMemoryError here: https://travis-ci.org/github/whitequark/parser/jobs/727303862

@eregon
Copy link

@eregon eregon commented Sep 17, 2020

For whatever reason it seems I cannot reproduce this in 3 runs: https://travis-ci.org/github/eregon/parser/builds

@iliabylich
Copy link
Collaborator Author

@iliabylich iliabylich commented Sep 17, 2020

right, it fails randomly, but I've noticed that the error comes on the last step of the test suite where we check that all AST nodes that are created are known for our AST visitor.

Here's the for_each_node method -

def for_each_node(&block)
, there are a few places in tests that call it. Basically, we record all nodes and do a couple of post-checks in the Minitest.after_run {} block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.