Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update related ids upon dataSet change. Fixes #402 #403

Merged
merged 1 commit into from Mar 6, 2020

Conversation

Xarthisius
Copy link
Collaborator

How to test?

  1. Register 1-2 datasets
  2. Create a Tale, add data from 1.
  3. Using Tale's metadata view confirm that the number of Cites relations matches entries in Datasets used

@codecov
Copy link

codecov bot commented Feb 28, 2020

Codecov Report

Merging #403 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
+ Coverage   90.65%   90.66%   +<.01%     
==========================================
  Files          47       47              
  Lines        3510     3513       +3     
==========================================
+ Hits         3182     3185       +3     
  Misses        328      328
Impacted Files Coverage Δ
server/lib/__init__.py 95.34% <100%> (+0.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca6c5c4...9e4cf5a. Read the comment docs.

@ThomasThelen ThomasThelen merged commit d901d49 into master Mar 6, 2020
@ThomasThelen ThomasThelen deleted the 402_update_relative_ids branch March 6, 2020 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants