Issue #504 #736
Merged
Issue #504 #736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks awesome! I'll test it out before merging ✅ |
|
Awesome, congrats on the house stuff! 👍 |
whyboris
reviewed
Mar 27, 2022
| @@ -1695,13 +1698,13 @@ export class HomeComponent implements OnInit, AfterViewInit { | |||
| clipSnippets: 5, | |||
| extractClips: false, | |||
| futureHubName: '', | |||
| isFixedNumberOfScreenshots: true, | |||
| screenshotSizeForImport: 288, // default | |||
| isFixedNumberOfScreenshots: this.wizard.isFixedNumberOfScreenshots ?? true, | |||
There was a problem hiding this comment.
I'm loving the nullish-coalescing here 👍
whyboris
reviewed
Mar 27, 2022
| @@ -1911,6 +1914,7 @@ export class HomeComponent implements OnInit, AfterViewInit { | |||
| shortcuts: this.shortcutService.keyToActionMap, | |||
| vhaFileHistory: this.vhaFileHistory, | |||
| windowSizeAndPosition: undefined, // is added in `cose-window` in `main.ts` | |||
| wizardOptions: this.wizard | |||
There was a problem hiding this comment.
😅 ah I see it! You're saving it 🎉
|
🙇 Thank you very much @23mwest for your contribution 🎉 Super awesome! During the review I thought I spotted a bug or two and commented, but have since then deleted the comments - I think everything is 💯 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry this took a while