diff --git a/.github/workflows/test-notebook.yml b/.github/workflows/test-notebook.yml index caa7440e99..deb340f980 100644 --- a/.github/workflows/test-notebook.yml +++ b/.github/workflows/test-notebook.yml @@ -41,8 +41,10 @@ jobs: restore-keys: | ${{ runner.os }}-pip- - name: Install dependencies - run: make install - - name: make kernel + run: | + make install + make + - name: make jupyter-kernel run: make jupyter-kernel - name: Run notebook test run: make test-notebooks diff --git a/examples/Dataset_Profiler_Viewer.ipynb b/examples/Dataset_Profiler_Viewer.ipynb index 54a9034df2..f90325f307 100644 --- a/examples/Dataset_Profiler_Viewer.ipynb +++ b/examples/Dataset_Profiler_Viewer.ipynb @@ -130,7 +130,7 @@ } ], "source": [ - "profile_viewer(profiles=[profile],output_path=\"/Users/leandro/Desktop/my_dataset.html\")" + "profile_viewer(profiles=[profile])" ] } ], diff --git a/test_notebooks/notebook_tests.py b/test_notebooks/notebook_tests.py index f3094bfcd8..64decdcd39 100644 --- a/test_notebooks/notebook_tests.py +++ b/test_notebooks/notebook_tests.py @@ -7,10 +7,8 @@ TEST_DIR = os.path.dirname(os.path.abspath(__file__)) PARENT_DIR = os.path.join(TEST_DIR, os.pardir) -skip_notebooks=["Guest Session Demo.ipynb", - "RAPIDS GPU Integration Example.ipynb", - "Analysis.ipynb", - "ROV-whylogs.ipynb" ] +skip_notebooks = ["Guest Session Demo.ipynb", "RAPIDS GPU Integration Example.ipynb", "Analysis.ipynb", "ROV-whylogs.ipynb"] + def process_notebook(notebook_filename, html_directory="notebook-html"): """ @@ -18,16 +16,15 @@ def process_notebook(notebook_filename, html_directory="notebook-html"): notebook to HTML (with outputs) and overwrites the .ipynb file (without outputs). """ - with open(notebook_filename) as f: nb = nbformat.read(f, as_version=4) - notebook_directory= os.path.abspath(os.path.dirname(notebook_filename)) + os.path.abspath(os.path.dirname(notebook_filename)) ep = ExecutePreprocessor(timeout=2000, kernel_name="whylogs-dev", allow_errors=False) try: # Check that the notebook runs - ep.preprocess(nb, {"metadata": {"path": os.path.join(PARENT_DIR,"examples")}}) + ep.preprocess(nb, {"metadata": {"path": os.path.join(PARENT_DIR, "examples")}}) except CellExecutionError: raise