Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix whylogs init #321

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Fix whylogs init #321

merged 1 commit into from
Sep 30, 2021

Conversation

jamie256
Copy link
Contributor

Description

Fix #311 by adding poetry scripts section to our pyproject.toml file and referencing the whylogs cli scripts.

Previously the whylogs cli and whylogs-demo were referenced in the setup.cfg as entry points, looks like it might have been missed when migrating to poetry.

You can verify this works locally by running

poetry install && poetry run whylogs init

General Checklist

  • Tests added for this feature/bug
    if it was a bug, test must cover it.
  • Conform by the style guides, by using formatter
  • Documentation updated
  • (optional) Please add a label to your PR

@jamie256 jamie256 added the bug Something isn't working label Sep 30, 2021
Copy link
Contributor

@andyndang andyndang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyndang andyndang enabled auto-merge (squash) September 30, 2021 16:21
@andyndang andyndang merged commit 5593f20 into mainline Sep 30, 2021
@andyndang andyndang deleted the dev/jamie/whylogs_init branch September 30, 2021 16:35
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1291852841

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.717%

Totals Coverage Status
Change from base Build 1289725357: 0.0%
Covered Lines: 3735
Relevant Lines: 4321

💛 - Coveralls

@jamie256 jamie256 mentioned this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

whylogs CLI is broken
3 participants