New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timezone format at pot creation #38

Merged
merged 1 commit into from Jun 17, 2014

Conversation

Projects
None yet
2 participants
@cedricmessiant
Contributor

cedricmessiant commented Jun 17, 2014

Remove colon because it breaks Babel when generating .po files

@wichert

This comment has been minimized.

Show comment
Hide comment
@wichert

wichert Jun 17, 2014

Owner

It's amazing how fragile Babel is. I'm curious why you are still using Babel to handle pot/po files; can you explain that to me? Perhaps there is something missing in lingua that I need to add.

Owner

wichert commented Jun 17, 2014

It's amazing how fragile Babel is. I'm curious why you are still using Babel to handle pot/po files; can you explain that to me? Perhaps there is something missing in lingua that I need to add.

wichert added a commit that referenced this pull request Jun 17, 2014

Merge pull request #38 from cedricmessiant/master
Fix timezone format at pot creation

@wichert wichert merged commit 10d1382 into wichert:master Jun 17, 2014

@cedricmessiant

This comment has been minimized.

Show comment
Hide comment
@cedricmessiant

cedricmessiant Jun 17, 2014

Contributor

I don't know ! What are the alternatives to Babel to generate .po files from pot files ?

Contributor

cedricmessiant commented Jun 17, 2014

I don't know ! What are the alternatives to Babel to generate .po files from pot files ?

@wichert

This comment has been minimized.

Show comment
Hide comment
@wichert

wichert Jun 17, 2014

Owner

All your need is lingua, as of lingua 2. Specifically all you need is the pot-create command it provides. The lingua documentation should explain everything you need.

Owner

wichert commented Jun 17, 2014

All your need is lingua, as of lingua 2. Specifically all you need is the pot-create command it provides. The lingua documentation should explain everything you need.

@cedricmessiant

This comment has been minimized.

Show comment
Hide comment
@cedricmessiant

cedricmessiant Jun 17, 2014

Contributor

I'm really sorry but I don't find an equivalent to this command in lingua documentation :

pybabel update -l fr -i messages.pot -D mydomain -o messages.po
Contributor

cedricmessiant commented Jun 17, 2014

I'm really sorry but I don't find an equivalent to this command in lingua documentation :

pybabel update -l fr -i messages.pot -D mydomain -o messages.po
@wichert

This comment has been minimized.

Show comment
Hide comment
@wichert

wichert Jun 17, 2014

Owner

There isn't one, by design. Updating and compiling PO files is handled by the standard msgmerge and msgfmt commands from standard gettext, and there is nothing to be gained by reimplementing those in Python. Since a reimplementation is only likely to introduce new bugs (and I have seen Babel corrupt PO files) I felt no need to go down that path.

The equivalent of your command is:

msgmerge messages.po messages.pot

and to compile that to a .mo file:

msgfmt messages.po
Owner

wichert commented Jun 17, 2014

There isn't one, by design. Updating and compiling PO files is handled by the standard msgmerge and msgfmt commands from standard gettext, and there is nothing to be gained by reimplementing those in Python. Since a reimplementation is only likely to introduce new bugs (and I have seen Babel corrupt PO files) I felt no need to go down that path.

The equivalent of your command is:

msgmerge messages.po messages.pot

and to compile that to a .mo file:

msgfmt messages.po
@cedricmessiant

This comment has been minimized.

Show comment
Hide comment
@cedricmessiant

cedricmessiant Jun 17, 2014

Contributor

Okay, thanks a lot !

Contributor

cedricmessiant commented Jun 17, 2014

Okay, thanks a lot !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment