bug in AnnotationsShiroAuthorizationStrategy implementation

[shuraa]

There is a typo in the AnnotationsShiroAuthorizationStrategy#isActionAuthorized method, that affectes checking for RENDER and ENABLE actions of an component's configuration phase.

ShiroSecurityConstraint fail = checkInvalidInstantiation(  findShiroSecurityConstraintAnnotations(componentClassAnnotations), ShiroAction.INSTANTIATE);

but shoud be

ShiroSecurityConstraint fail = checkInvalidInstantiation(findShiroSecurityConstraintAnnotations(componentClassAnnotations), _action);

[sturmm]

+1

[martin-g]

Please create a Pull Request and we will merge it.
Thanks!

[sturmm]

Working on it :)

[shuraa]

Thank you!

[sturmm]

How can I build the master?

How can I build the project for executing unit tests? I've checked out the master of the wicketstuff repo. The project needs wicket 6.9.0-SNAPSHOT as dependency. So I checked out build/wicket-6.9.0 branch from the wicket repo. When I execute the maven build here I got the version 6.9.1-SNAPSHOT ... When I checkout the tag wicket-6.9.0 maven will build wicket-6.9.0 (no snapshot). I don't like commit something without being able to execute unit tests.

[sturmm]

Done. Pull request #239

[tkruse]

@RoadRunner120485 : PR seems merged, I guess this can be closed?