Skip to content

DataGrid row selection indication is broken #89

Closed
czajawt opened this Issue Jan 19, 2012 · 4 comments

2 participants

@czajawt
czajawt commented Jan 19, 2012

In DataGridBody with commit 2e5023f
line 187 was changed from getDefaultModel() to getDefaultItemModel().
With this change model returned is for DataGridBody not RowItem and thus isItemSelected returns false.
Row is internally selected (is in selectedItems in DataGrid ) but is not highlited on clients side.
IMHO line 187 should be: (isItemSelected((IModel)getDefaultModel()))

@martin-g
WicketStuff member
martin-g commented Mar 1, 2012

With 6.0-SNAPSHOT (de)selecting works OK.

@dsoneira dsoneira added a commit to dsoneira/wicketstuff-core that referenced this issue Mar 28, 2012
@dsoneira dsoneira fixed issue #89 (DataGrid selection indication is broken) c037ddc
@czajawt
czajawt commented Apr 4, 2012

Problem was fixed by 7e8103d but merge f286b70 reverted fixup :-(

@martin-g
WicketStuff member
martin-g commented Apr 5, 2012

The fix is restored!

@czajawt
czajawt commented Apr 5, 2012

Works with Wicket 6.0-beta1 and current inmethod-grid.
Thanks !!

@czajawt czajawt closed this Apr 5, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.