Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

fixed grid initialization script rendering #33

Merged
merged 2 commits into from Jun 23, 2011

Conversation

Projects
None yet
2 participants
Contributor

shuraa commented Jun 17, 2011

  • initialization script is get called once DOM is ready

fixes issue #32

shuraa added some commits Jun 17, 2011

fixed grid initialization script rendering
- initialization script is get called once DOM is ready

fixes issue #32
Fix realItemCount calculation
- take in account data source with unknown
  count and case, when total count is set to NO_MORE_ITEM
  (i.e. empty data source)

akiraly added a commit that referenced this pull request Jun 20, 2011

Member

akiraly commented Jun 20, 2011

I have ported your patch to the 1.5 branch with 90552bd and everything seems to be ok there.

Contributor

shuraa commented Jun 21, 2011

akiraly, did you check grid behavior under latest Google Chrome in case of AJAX ?

Member

akiraly commented Jun 21, 2011

I just made a test with your example (ported to 1.5, modified to load grid on ajax call) with Chrome 12. Seems to be ok except that the column for "Name" is not rendered correctly (visually). But that visual error is present if it is loaded non-ajax way and clicked on the "Name" column header once. Other browsers don't show this behavior.

Contributor

shuraa commented Jun 23, 2011

Today I check carefully pached version of inmethod-grid for core-1.4.x under Win7 and the following browser:

  • FF4/5
  • IE8/9
  • Opera 11
  • Chrome 12
    Everthing looks fine. Can I merge pull request by myself or should I wait for community votes ?
    Later I'll try to port the patches to master branch.
Member

akiraly commented Jun 23, 2011

Feel free to do it.

shuraa added a commit that referenced this pull request Jun 23, 2011

Merge pull request #33 from shuraa/core-1.4.x
fixed grid initialization script rendering

@shuraa shuraa merged commit f87c402 into wicketstuff:core-1.4.x Jun 23, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment