Use only Subject to check permissions, not SecurityManager #58

Closed
wants to merge 1 commit into from

2 participants

@duesenklipper

I changed the auth strategy to only use the Subject to check permissions - asking the SecurityManager itself is not necessary.

By using only the Subject testing is simplified, because only the subject needs to be mocked.

This is the fix for the 1.4 branch.

@martin-g
WicketStuff member

There are a lot of formatting noise which makes the code review very hard.

@martin-g
WicketStuff member

Closing this PR as outdated.
Please open a new one against master branch if the improvement is still applicable.

@martin-g martin-g closed this Jan 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment