This repository has been archived by the owner on Nov 8, 2021. It is now read-only.
Added option to remove email domain from usernames #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I added one inline comment because the current implementation does not get all users, only the first page.
My other concern here is that getting the list of all users additionally will take time which slows down the login procedure (and we already have users complaining about the long waiting times during login).
| raw_username=${raw_username//".comma."/","} | ||
|
|
||
| if [ "${STRIP_EMAILS_FROM_USERNAME}" -eq 1 ]; then | ||
| iam_username=$(aws iam list-users --query "Users[*].[UserName]" --output text | fgrep "$raw_username@") |
There was a problem hiding this comment.
this will only get the first page of users. So with many IAM users, not all users will be returned on the first page.
|
@michaelwittig do you have any plans to complete the work started here? If not, I could have a go at rehashing? Think enough people would find this useful. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's often the case that people will have their email addresses as their IAM usernames and I'd say it's pretty much always the case that they wouldn't want that as part of their local EC2 username.
This allows the option of stripping the domain from their username so
user.name@email.comwill become simplyuser.name.Note that to reverse-engineer the remainder of the username, we look up the IAM users via the cli. This means usernames must be unique, exclusive of the email domain. E.g.
my.user@email.comandmy.user@anotherEmail.comwill not be differentiated and will not be able to use this method.I'd suggest this become the default behaviour, but have not made that the case in this PR in order to maintain backwards compatibility.