Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Changelog #4820

Merged
merged 48 commits into from
May 14, 2021
Merged

Update Changelog #4820

merged 48 commits into from
May 14, 2021

Conversation

Noordfrees
Copy link
Member

Should not be merged until winter time freeze as there will be a few more commits incoming. Can already be reviewed though.

@Noordfrees Noordfrees self-assigned this Apr 18, 2021
Copy link
Contributor

@klaus-halfmann klaus-halfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing "Use CMD as default modifier for macOS"

Copy link
Contributor

@klaus-halfmann klaus-halfmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No chance to check if this is complete, thanks for your work

Copy link
Member

@matthiakl matthiakl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes there is an issue number in the front, which is a bit misleading. I would remove them.
Otherwise looks fine and well organized.
Thanks for your work.

ChangeLog Outdated Show resolved Hide resolved
ChangeLog Outdated Show resolved Hide resolved
ChangeLog Outdated Show resolved Hide resolved
ChangeLog Outdated Show resolved Hide resolved
ChangeLog Outdated Show resolved Hide resolved
@frankystone
Copy link
Contributor

Many thanks for taking this up! 👍 🥇

@Noordfrees
Copy link
Member Author

@frankystone I'm wondering, would adding [TOC] to the top of the Changelog file work on the homepage? The online version of the changelog is nearly impossible to navigate so I'd find it helpful to add a table of contents there.

@frankystone
Copy link
Contributor

@frankystone I'm wondering, would adding [TOC] to the top of the Changelog file work on the homepage? The online version of the changelog is nearly impossible to navigate so I'd find it helpful to add a table of contents there.

Yes this should work, but only partly. The TOC get rendered but the corresponding CSS is missing to place the TOC on the right side and give it some coloring. Will look into this.

@frankystone
Copy link
Contributor

@Noordfrees Noordfrees marked this pull request as ready for review May 14, 2021 11:52
@Noordfrees Noordfrees merged commit 857dd74 into widelands:master May 14, 2021
@Noordfrees Noordfrees deleted the changelog branch May 14, 2021 11:52
- Trainingsites only evaluate fish/meat substitutes if present in inputs (#4641)
- Delay AI initalization after scenario init (#4656)
- Fixed an unsafe AI time operation (#4749)
- AI production support (#4618)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for being late but this was such a big change that it would fit better with the bullet points from #4618 and #4465 as sub points,

bunnybot pushed a commit that referenced this pull request May 20, 2024
Co-authored-by: Benedikt Straub <benedikt-straub@web.de>
Co-committed-by: Benedikt Straub <benedikt-straub@web.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants