-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: AR support #397
base: master
Are you sure you want to change the base?
WIP: AR support #397
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, however for some reason it seems the center of the box seems to be placed at the floor, I will check that out. 2 small changes requested.
js/src/ar.js
Outdated
renderer.xr.setSession(null); | ||
lastXrTransform = null; | ||
showCloseOverlay(false); | ||
renderer.setAnimationLoop(() => null); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renderer.setAnimationLoop(() => null); | |
renderer.setAnimationLoop(null); |
Otherwise we still render continuous after stopping.
js/src/figure.ts
Outdated
}); | ||
} | ||
this.arRootPositionBackup = this.model.get("box_center").concat(); | ||
this.model.set("box_center", [0.5, 0.5,-3]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.model.set("box_center", [0.5, 0.5,-3]); | |
this.model.set("box_center", [0.5, 0.5, -3]); |
Sharing the demo: ipyvolume-ar-scatter-no-audio.mp4It seems also that the floor is moving wrt the scene btw. |
To reproduce the klein bottle:
To make sure we pick up the right ipyvolume from this branch:
Open from your phone:: https:///ar.html (ignore the self signed certificate and continue) @mariobuikhuizen can you share the link where all supported devices are listed? |
Supported devices: https://developers.google.com/ar/devices. For iOS https://labs.mozilla.org/projects/webxr-viewer/ can be used. |
@maartenbreddels how can I get your example running? Where does the python code go? |
just execute it from anywhere, in a script, or from the REPL, since we save it to HTML, no jupyter environment is needed. |
Ah, missed the saving to HTML. |
I'm a little late to the party, but I noticed you all aren't using a notebook review tool and wanted to invite you to review this pull request with GitNotebooks: https://gitnotebooks.com/widgetti/ipyvolume/pull/397 It lets you do things like comment on rendered markdown and code cells, so might be an easy win for your PR reviews. |
No description provided.