fix: calling after a 'subscript' trigger a warning when validating hooks

Author: maartenbreddels

solara/validate_hooks.py

@@ -142,14 +142,12 @@ def visit_Call(self, node: ast.Call):
         if isinstance(func, ast.Call):
             # Nested function, it will appear in another node later
             return
+        id_ = None
         if isinstance(func, ast.Name):
             id_ = func.id
         elif isinstance(func, ast.Attribute):
             id_ = func.attr
-        else:
-            warnings.warn(f"Unexpected function node type: {func}, line={node.lineno}")
-            return
-        if self.matches_use_function(id_):
+        if id_ is not None and self.matches_use_function(id_):
             self.error_on_early_return(node, id_)
             self.error_on_invalid_scope(node, id_)
         self.generic_visit(node)

tests/unit/hook_use_invalid_test.py

@@ -70,6 +70,14 @@ def Page3():  # noqa: SH103
         solara.Text("Done")
 
 
+def test_hook_validate_ast_checks():
+    # a Call on a Subscript failed
+    @solara.component
+    def Page4():
+        funcs = [lambda x: x]
+        funcs[0](1)
+
+
 def test_hook_use_invalid_conditional():
     with hook_check_warn(), pytest.warns(UserWarning):