feat: Chat components, and AI example of use #384
Merged
+437
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
iisakkirotko
force-pushed
the
feat-chat-components
branch
2 times, most recently
from
89485a7 to
8e73bfc
Compare
iisakkirotko
force-pushed
the
feat-chat-components
branch
from
2c6dc09 to
7071f64
Compare
maartenbreddels
requested changes
Nov 22, 2023
Contributor
maartenbreddels
left a comment
maartenbreddels
left a comment
There was a problem hiding this comment.
Exciting, starting to look really good!
The comments on solara/website/pages/examples/ai/chatbot.py I'm not so sure about, I feel a bit torn there. I think on the one hand it shows the flexibility of these components and solara, while at the same time the code may be a bit overwhelming... i think we need to digest this a bit and maybe do another call on this.
iisakkirotko
force-pushed
the
feat-chat-components
branch
5 times, most recently
from
cb8ad7a to
ddaeb5d
Compare
maartenbreddels
force-pushed
the
feat-chat-components
branch
2 times, most recently
from
92662f0 to
85bd5eb
Compare
iisakkirotko
force-pushed
the
feat-chat-components
branch
from
f7ba796 to
f586971
Compare
maartenbreddels
requested changes
Nov 24, 2023
Contributor
maartenbreddels
left a comment
maartenbreddels
left a comment
There was a problem hiding this comment.
If you can add style and classes arguments, and we can merge :)
iisakkirotko
force-pushed
the
feat-chat-components
branch
2 times, most recently
from
6da8301 to
2bbf476
Compare
maartenbreddels
requested changes
Nov 27, 2023
Contributor
maartenbreddels
left a comment
maartenbreddels
left a comment
There was a problem hiding this comment.
Exciting... almost done I think :)
Collaborator
Author
It's about the process, right? |
Co-authored-by: Maarten Breddels <maartenbreddels@gmail.com>
maartenbreddels
force-pushed
the
feat-chat-components
branch
from
caa681f to
41d766c
Compare
iisakkirotko
force-pushed
the
feat-chat-components
branch
from
76888dc to
e6bf442
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs done. Test missing.