feat: get_kernel_id and get_session_id for custom storage #452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @maartenbreddels and the rest of your teammates on |
This was referenced Jan 10, 2024
maartenbreddels
force-pushed
the
01-09-feat_get_kernel_id_and_get_session_id_for_custom_storage
branch
from
44f1332 to
8a06e32
Compare
maartenbreddels
force-pushed
the
01-09-feat_get_kernel_id_and_get_session_id_for_custom_storage
branch
from
8a06e32 to
c6fba36
Compare
maartenbreddels
changed the base branch from
master
to
01-18-feat_on_kernel_start_triggers_callback_on_virtual_kernel_start
This was referenced Jan 19, 2024
iisakkirotko
force-pushed
the
01-18-feat_on_kernel_start_triggers_callback_on_virtual_kernel_start
branch
from
0933395 to
a99f167
Compare
This was referenced Feb 5, 2024
iisakkirotko
force-pushed
the
01-09-feat_get_kernel_id_and_get_session_id_for_custom_storage
branch
from
c6fba36 to
eb57a3a
Compare
iisakkirotko
changed the base branch from
01-18-feat_on_kernel_start_triggers_callback_on_virtual_kernel_start
to
master
iisakkirotko
reviewed
Feb 9, 2024
Collaborator
iisakkirotko
left a comment
iisakkirotko
left a comment
There was a problem hiding this comment.
Suggesting some changes to documentation. Otherwise looks good!
solara/website/pages/docs/content/20-understanding/50-solara-server.md
Outdated
Show resolved
Hide resolved
solara/website/pages/docs/content/20-understanding/50-solara-server.md
Outdated
Show resolved
Hide resolved
solara/website/pages/docs/content/20-understanding/50-solara-server.md
Outdated
Show resolved
Hide resolved
solara/website/pages/docs/content/20-understanding/50-solara-server.md
Outdated
Show resolved
Hide resolved
If you want to store data in a custom storage, you need to know the kernel_id or session_id to scope. This can be used to implement something similar to reactive variables.
maartenbreddels
force-pushed
the
01-09-feat_get_kernel_id_and_get_session_id_for_custom_storage
branch
from
eb57a3a to
4ad5b50
Compare
Contributor
Author
|
Great, thanks you! I left state (i prefer that to states, since it's not often used that way), but the rest were good changes! |
Collaborator
|
Then I feel like there should be an article in front of "state", i.e. "the state" or "a state", otherwise it sounds very strange, but maybe that's just me. |
maartenbreddels
added a commit
that referenced
this pull request
Feb 9, 2024
* feat: get_kernel_id and get_session_id for custom storage If you want to store data in a custom storage, you need to know the kernel_id or session_id to scope. This can be used to implement something similar to reactive variables.
maartenbreddels
added a commit
that referenced
this pull request
Feb 9, 2024
* feat: get_kernel_id and get_session_id for custom storage If you want to store data in a custom storage, you need to know the kernel_id or session_id to scope. This can be used to implement something similar to reactive variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you want to store data in a custom storage, you need to know the
kernel_id or session_id to scope.
This can be used to implement something similar to reactive variables.