Skip to content

feat: task and use_task for better asyncio task a thread execution - #461

Merged
maartenbreddels merged 1 commit into
masterfrom
01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution
Feb 16, 2024
Merged

feat: task and use_task for better asyncio task a thread execution#461
maartenbreddels merged 1 commit into
masterfrom
01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution

Conversation

@maartenbreddels

@maartenbreddels maartenbreddels commented Jan 12, 2024

Copy link
Copy Markdown
Contributor

use_task can replace use_thread, but also support coroutine functions.

task is a decorator that creates a top level task that can be executed
from any location (e.g. a click handler of a button).

This was referenced Jan 12, 2024
Merged
Merged
Merged
Merged
@maartenbreddels Graphite App

maartenbreddels commented Jan 12, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @maartenbreddels and the rest of your teammates on Graphite Graphite

@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from cf13f50 to 64e8e1c Compare January 12, 2024 12:17
@maartenbreddels
maartenbreddels force-pushed the 01-10-feat_Computed_reactive_variables_and_Singleton branch from 530c72b to 2a2db1c Compare January 12, 2024 13:02
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from 64e8e1c to 2398ddd Compare January 12, 2024 13:02
iisakkirotko
iisakkirotko requested changes Jan 12, 2024
View reviewed changes

@iisakkirotko iisakkirotko left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is definitely going to have some demand! I'll give a possible different example in the docs some more thought.

Comment thread solara/website/pages/api/task.py Outdated
Comment thread solara/website/pages/api/use_task.py Outdated
Comment thread solara/website/pages/docs/content/10-howto/30-tasks.md Outdated
Comment thread solara/tasks.py Outdated
Comment thread solara/tasks.py Outdated
state=solara.ResultState.INITIAL,
)
)
# self.thread_pool = ThreadPoolExecutor(max_workers=1)

@iisakkirotko iisakkirotko Jan 12, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# self.thread_pool = ThreadPoolExecutor(max_workers=1)

Comment thread solara/tasks.py Outdated
Comment thread solara/tasks.py Outdated
Comment thread solara/tasks.py Outdated
@maartenbreddels
maartenbreddels force-pushed the 01-10-feat_Computed_reactive_variables_and_Singleton branch from 2a2db1c to f4e000c Compare January 18, 2024 09:33
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from 2398ddd to 9a3277d Compare January 18, 2024 09:33
@maartenbreddels
maartenbreddels changed the base branch from 01-10-feat_Computed_reactive_variables_and_Singleton to master January 19, 2024 10:46
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from eaced63 to 283ffff Compare January 19, 2024 10:47
@maartenbreddels
maartenbreddels changed the base branch from master to 01-10-feat_Computed_reactive_variables_and_Singleton January 19, 2024 10:47
@maartenbreddels maartenbreddels mentioned this pull request Jan 19, 2024
Merged
@maartenbreddels
maartenbreddels force-pushed the 01-10-feat_Computed_reactive_variables_and_Singleton branch from fd38bdc to d729d5d Compare January 19, 2024 12:58
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from 283ffff to 7288e79 Compare January 19, 2024 12:58
This was referenced Jan 19, 2024
Draft
Draft
@maartenbreddels
maartenbreddels force-pushed the 01-10-feat_Computed_reactive_variables_and_Singleton branch from d729d5d to 96720b1 Compare January 19, 2024 19:42
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from 7288e79 to 86758cc Compare January 19, 2024 19:42
@maartenbreddels
maartenbreddels force-pushed the 01-10-feat_Computed_reactive_variables_and_Singleton branch 3 times, most recently from 3e25f02 to c2c3c95 Compare January 22, 2024 11:48
@iisakkirotko
iisakkirotko force-pushed the 01-10-feat_Computed_reactive_variables_and_Singleton branch from c2c3c95 to 0134661 Compare February 5, 2024 13:36
@iisakkirotko
iisakkirotko force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from 86758cc to 06c4657 Compare February 5, 2024 13:36
This was referenced Feb 5, 2024
Merged
Closed
@iisakkirotko
iisakkirotko force-pushed the 01-10-feat_Computed_reactive_variables_and_Singleton branch 2 times, most recently from 6acaeba to 5b55459 Compare February 8, 2024 16:14
@iisakkirotko
iisakkirotko force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from 899a669 to 850c94b Compare February 8, 2024 16:14
@maartenbreddels
maartenbreddels force-pushed the 01-10-feat_Computed_reactive_variables_and_Singleton branch 2 times, most recently from 7bd5707 to 7d63ad0 Compare February 9, 2024 16:10
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from 850c94b to 5928f23 Compare February 10, 2024 14:39
@maartenbreddels
maartenbreddels changed the base branch from 01-10-feat_Computed_reactive_variables_and_Singleton to master February 10, 2024 14:42
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch 2 times, most recently from 99bb183 to 6e30237 Compare February 12, 2024 13:25
maartenbreddels added a commit that referenced this pull request Feb 12, 2024
@maartenbreddels
chore: upgrade mypy to 1.1.1
0099274 
This is required for #461
but upgrading to an even never version will lead to many errors/issues.
This version is the smallest upgrade that fixes the issue for this PR.
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch 4 times, most recently from 1f4fc86 to d39063b Compare February 14, 2024 16:50
maartenbreddels added a commit that referenced this pull request Feb 15, 2024
@maartenbreddels
chore: upgrade mypy to 1.1.1
f7bfb29 
This is required for #461
but upgrading to an even never version will lead to many errors/issues.
This version is the smallest upgrade that fixes the issue for this PR.
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch 4 times, most recently from 3cea2ab to fcea18f Compare February 15, 2024 15:05
maartenbreddels added a commit that referenced this pull request Feb 16, 2024
@maartenbreddels
chore: upgrade mypy to 1.6.0
b8e1ad4 
This is required for #461
but upgrading to an even never version will lead to many errors/issues.
This version is the smallest upgrade that fixes the issue for this PR.

Note that was previously done in f7bfb29
but due to further changes we need to upgrade again.
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from fcea18f to 48b5d63 Compare February 16, 2024 11:15
maartenbreddels added a commit that referenced this pull request Feb 16, 2024
@maartenbreddels
chore: upgrade mypy to 1.6.0
5a6afaf 
This is required for #461
but upgrading to an even never version will lead to many errors/issues.
This version is the smallest upgrade that fixes the issue for this PR.

Note that was previously done in f7bfb29
but due to further changes we need to upgrade again.
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch 2 times, most recently from 1c11cf2 to f981cfd Compare February 16, 2024 12:16
maartenbreddels added a commit that referenced this pull request Feb 16, 2024
@maartenbreddels
chore: upgrade mypy to 1.6.0
13382dc 
This is required for #461
but upgrading to an even never version will lead to many errors/issues.
This version is the smallest upgrade that fixes the issue for this PR.

Note that was previously done in f7bfb29
but due to further changes we need to upgrade again.
@maartenbreddels
feat: task and use_task for better asyncio task a thread execution
a9f836f 
use_task can replace use_thread, but also support coroutine functions.

task is a decorator that creates a top level task that can be executed
from any location (e.g. a click handler of a button).
@maartenbreddels
maartenbreddels force-pushed the 01-12-feat_task_and_use_task_for_better_asyncio_task_a_thread_execution branch from f981cfd to a9f836f Compare February 16, 2024 13:34
@maartenbreddels
maartenbreddels merged commit db9063e into master Feb 16, 2024
@iisakkirotko iisakkirotko mentioned this pull request Feb 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iisakkirotko iisakkirotko iisakkirotko requested changes
@mariobuikhuizen mariobuikhuizen Awaiting requested review from mariobuikhuizen

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@maartenbreddels @iisakkirotko