fix: user reactive variables taking on solara builtin variable values on hot reload#514
Merged
iisakkirotko merged 1 commit intomasterfrom Feb 23, 2024
Conversation
… on hot reload Sometimes on hot reload, when the value of a user-defined reactive variable is reset, the value would get updated to that of a solara builtin reactive variable. We avoid this here by manually fixing keys for our variables
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @iisakkirotko and the rest of your teammates on |
maartenbreddels
approved these changes
Feb 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes on hot reload, when the value of a user-defined reactive variable is reset, the value would get updated to that of a solara builtin reactive variable. We avoid this here by manually fixing keys for our variables
Should fix #510 for
solara.lab.cookies/headers