feat: make the server (starlette) work without threads for pyodide - #569
Merged
Merged
Conversation
maartenbreddels
force-pushed
the
feat_server_async
branch
4 times, most recently
from
March 23, 2024 20:37
58b59f2 to
2a16fb4
Compare
maartenbreddels
marked this pull request as ready for review
March 23, 2024 20:40
maartenbreddels
force-pushed
the
feat_server_async
branch
from
March 25, 2024 12:06
2a16fb4 to
2db9a19
Compare
|
Your Render PR Server URL is https://solara-stable-pr-569.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-co0mhfacn0vc73dq62ug. |
in pyodide (pycafe) we cannot use threads. We currently have workarounds in pycafe, but it would be easier to just not use threads in the server if they are not available.
maartenbreddels
force-pushed
the
feat_server_async
branch
from
March 25, 2024 13:47
2db9a19 to
27c87bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in pyodide (pycafe) we cannot use threads. We currently have workarounds in pycafe, but it would be easier to just not use threads in the server if they are not available.