New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autogen.sh eats $1 instead of passing to configure #103

Closed
mhaas opened this Issue Mar 18, 2015 · 5 comments

Comments

Projects
None yet
2 participants
@mhaas
Contributor

mhaas commented Mar 18, 2015

If you run

./autogen.sh --enable-cyassl

then enable--cyassl gets saved to $BUILDROOT and weird stuff ensues.

if [ "X$1" != "X" ]
then
    BUILDROOT=`echo "$1" | sed 's/^[^=]*[=]//'`
    [..]
   CC=${BUILDROOT}/build_mipsel/staging_dir/bin/mipsel-linux-uclibc-gcc

@mhaas mhaas added this to the 1.3.0 milestone Mar 18, 2015

@acv acv added the modernization label Mar 19, 2015

@acv

This comment has been minimized.

Show comment
Hide comment
@acv

acv Mar 19, 2015

Contributor

This was needed back in the days to build packages. Is this still needed? Does it even work?

Contributor

acv commented Mar 19, 2015

This was needed back in the days to build packages. Is this still needed? Does it even work?

@mhaas

This comment has been minimized.

Show comment
Hide comment
@mhaas

mhaas Mar 19, 2015

Contributor

It is not needed on current Openwrt sdks. You can probably set $CC and be good.

Contributor

mhaas commented Mar 19, 2015

It is not needed on current Openwrt sdks. You can probably set $CC and be good.

@acv

This comment has been minimized.

Show comment
Hide comment
@acv

acv Mar 19, 2015

Contributor

Cool, I should get an openwrt SDK and play with it, last time I tried in the summer of '04 it was a pretty rough system.

Contributor

acv commented Mar 19, 2015

Cool, I should get an openwrt SDK and play with it, last time I tried in the summer of '04 it was a pretty rough system.

@mhaas

This comment has been minimized.

Show comment
Hide comment
@mhaas

mhaas Mar 19, 2015

Contributor

With current OpenWRT SDKs, you need the Makefile (package recipe) we were talking about in that other ticket. You can probably just use their CC and make that work. With the Makefile, I only ever update the version and re-compile. That's tolerable for me, so I have no use for the current hack to directly use a cross-compiler.

Contributor

mhaas commented Mar 19, 2015

With current OpenWRT SDKs, you need the Makefile (package recipe) we were talking about in that other ticket. You can probably just use their CC and make that work. With the Makefile, I only ever update the version and re-compile. That's tolerable for me, so I have no use for the current hack to directly use a cross-compiler.

@acv

This comment has been minimized.

Show comment
Hide comment
@acv

acv Mar 19, 2015

Contributor

Then PR should be made with:

  1. This hack removed.
  2. A readme type file with up to date and working build instructions.
Contributor

acv commented Mar 19, 2015

Then PR should be made with:

  1. This hack removed.
  2. A readme type file with up to date and working build instructions.

acv added a commit to acv/wifidog-gateway that referenced this issue Mar 22, 2015

@mhaas mhaas modified the milestones: 1.2.1, 1.3.0 Mar 23, 2015

@mhaas mhaas closed this in #144 Mar 24, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment