Skip to content

Libhttpd fixes #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acv merged 2 commits into from
Mar 25, 2015
Merged

Libhttpd fixes #160

acv merged 2 commits into from
Mar 25, 2015

Conversation

@acv
Copy link
Contributor

@acv acv commented Mar 25, 2015

All issues that coverity found:

  • No error check on setsockopt
  • Two strcpy into fixed-sized buffers
  • Possibly non-terminanted string
  • httpd_output variable expansion could exceed buffer length
  • va_end() not called

acv added a commit that referenced this pull request Mar 25, 2015
@acv
Merge pull request #160 from acv/libhttpd-fixes
684bbc2 
Libhttpd fixes
@acv acv merged commit 684bbc2 into wifidog:master Mar 25, 2015
@acv acv deleted the libhttpd-fixes branch March 25, 2015 01:14
@florida63 florida63 added this to the 1.2.1 milestone Mar 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2.1

Development

Successfully merging this pull request may close these issues.

2 participants

@acv @florida63