Partial rewrite of fw_sync_with_auth#168
Merged
mhaas merged 15 commits intowifidog:masterfrom Apr 1, 2015
Merged
Conversation
Contributor
|
Damn, you were about 10 seconds faster than me. Just finished my compile :) |
Goal is to eventually have them check and cleanup previous Mark automatically.
Contributor
Author
|
Last few commits mostly deal with issue #55 at least in theory |
Contributor
|
I test. |
Contributor
src/http.c
Outdated
Contributor
There was a problem hiding this comment.
Something I have noticed here: can't we use logout_client from firewall.c here?
Contributor
Author
|
Indeed! Bonus point, the code in firewall.c was cleaner and with better thread safety. |
Contributor
|
Ok, I am all happy now that I have #173. |
mhaas
added a commit
that referenced
this pull request
Apr 1, 2015
Partial rewrite of fw_sync_with_auth
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code needs a lot of testing and probably has remaining bugs but it attempts to avoid being affected by client_list changes in any way.
The trick is that the entire client list gets duplicated and the mutex is dropped and then the copy is processed.
Mutex are re-acquired and the client refound (by mac and ip) before being changed. Explicit checks exist for client that no longer exist.
This aims at resolving #84