fetch_page_wikiprojects: Fix page processing logic #13
+11
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If 'lastrevid' or 'title' is not returned in response, the response processing logic errors out. Fix this by initializing 'lastrevid' with -1 and 'title' with a blank string and only populating them after checking their presence in response Modified test case to catch this error
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 50.65% 51.02% +0.36%
==========================================
Files 10 10
Lines 535 539 +4
==========================================
+ Hits 271 275 +4
Misses 264 264
Continue to review full report at Codecov.
|
halfak
reviewed
Dec 19, 2017
| {'talk_page_id': pageid, | ||
| 'rev_id': page_doc['lastrevid'], 'templates': [], | ||
| 'talk_page_title': page_doc['title']} | ||
| 'rev_id': -1, 'templates': [], |
Member
There was a problem hiding this comment.
A more straightforward way to do this would be page_doc.get('lastrevid', -1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If 'lastrevid' or 'title' is not returned in response, the response
processing logic errors out.
Fix this by initializing 'lastrevid' with -1 and 'title' with a blank
string and only populating them after checking their presence in
response
Modified test case to catch this error
Phab: https://phabricator.wikimedia.org/T181522