ui: Invoke the createTable function regardless of response #213
Conversation
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 45.45% 45.45%
=======================================
Files 3 3
Lines 77 77
=======================================
Hits 35 35
Misses 42 42Continue to review full report at Codecov.
|
ores/wsgi/static/js/scorer.js
Outdated
| @@ -79,14 +79,14 @@ function getResults() { | |||
| }); | |||
| models_url = models_url.slice(0, -1); | |||
| var url = "/scores/" + $('#wikiDropDownInput').attr('value') + "/?models=" + models_url + "&revids=" + revs; | |||
| $.get(url, function (data) { | |||
| $.get(url, datatype='jsonp').always(function(data) { | |||
There was a problem hiding this comment.
Why not e.g. /* datatype= */ 'jsonp' to avoid creating unused variable? 😉
|
There's a rendering issue where it seems the error pane isn't fully removed after an error occurs and a new revid is scored. Not sure if it is related to this specific change or not. Steps reproduce:
|
|
@halfak fixed. It's way cleaner now |
ores/wsgi/static/js/scorer.js
Outdated
| } | ||
| $('#tableContainer').remove(); |
There was a problem hiding this comment.
I think maybe you want to clear the children -- not remove the container.
There was a problem hiding this comment.
hmm, Let me see what I can do about it.
This one basically cleans everything and replace new one instead
Bug: T149118