Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-admins cannot close CFDs with more than 50 categories #60

Open
NovemLinguae opened this issue Jun 2, 2024 · 1 comment · May be fixed by #87
Open

non-admins cannot close CFDs with more than 50 categories #60

NovemLinguae opened this issue Jun 2, 2024 · 1 comment · May be fixed by #87

Comments

@NovemLinguae
Copy link
Member

Reported by Qwerfjkl at https://en.wikipedia.org/wiki/Wikipedia_talk:XFDcloser#Most_urgent_bugs

Probably hitting the API limit for non-admins. Need to put the API query in a loop, or use the API's continue feature, or something.

@Qwerfjkl
Copy link

Qwerfjkl commented Jun 2, 2024

I suspect it's from

fetchInfoFromApi() {
const pagesExistencesPromise = API.get({
action: "query",
format: "json",
formatversion: 2,
titles: this.model.pagesNames,
prop: "info",
inprop: "talkid"
}).then(response => response.query.pages.forEach(page => {
const pageTitle = mw.Title.newFromText(page.title);
const talkpageTitle = pageTitle.getTalkPage();
mw.Title.exist.set(pageTitle.getPrefixedDb(), !page.missing);
if ( talkpageTitle ) {
mw.Title.exist.set(talkpageTitle.getPrefixedDb(), !!page.talkid);
}
}));

though it might be better to handle this in api.js.

@Qwerfjkl Qwerfjkl linked a pull request Jun 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants