Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple warning for users without JavaScript #105

Merged
merged 2 commits into from Aug 15, 2019

Conversation

@aezell
Copy link
Contributor

commented Aug 14, 2019

We can make this fancier, but this is just to have something simple
until we can design a nicer look. This avoids the blank white page
that a no JS user currently receives.

Clearly, this is English-only. Think incrementalism.

Bug: T185785

Add a simple warning for users without JavaScript
We can make this fancier, but this is just to have something simple
until we can design a nicer look. This avoids the blank white page
that a no JS user currently receives.

Clearly, this is English-only. Think incrementalism.

Bug: T185785
@@ -19,6 +19,7 @@
<div id="root"></div>
<noscript>
<p>
This tool requires JavaScript to function. If you do not want to enable Javascript, you will continue to be unable to use this tool.

This comment has been minimized.

Copy link
@davidbarratt

davidbarratt Aug 14, 2019

Member

That second sentence feels unnecessary. Otherwise this is good. :)

This comment has been minimized.

Copy link
@aezell

aezell Aug 15, 2019

Author Contributor

Cool. I removed that sentence.

Update to one sentence
Brevity is the soul of wit.

@davidbarratt davidbarratt merged commit 5c4f330 into master Aug 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@davidbarratt davidbarratt deleted the warn_nojs branch Aug 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.