Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSS and LESS variables for each color #25

Closed
wants to merge 1 commit into from
Closed

Add CSS and LESS variables for each color #25

wants to merge 1 commit into from

Conversation

juliengirault
Copy link
Contributor

Volker-E
Volker-E requested changes Apr 7, 2017
View reviewed changes
Copy link
Collaborator

@Volker-E Volker-E left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback given at https://phabricator.wikimedia.org/T162329#3164578

@Volker-E
Copy link
Collaborator

Volker-E commented Sep 5, 2017

After consulting other Design team members, it was decided that this is unwanted redundant information, devs will be able to make the connection between for example “Base70” and var( --wmui-color-base70 ) for CSS or @wmui-color-base70 for LESS.

@Volker-E Volker-E closed this Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Volker-E Volker-E Volker-E requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliengirault @Volker-E