Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Legal informations now visible and links activated. Fixes #34170 and #34030 #182

Closed
wants to merge 2 commits into from

2 participants

@astagi

Ok this pull request fixes following bugs:

1) https://bugzilla.wikimedia.org/show_bug.cgi?id=34170

and related

2) https://bugzilla.wikimedia.org/show_bug.cgi?id=34030

To a better about page and beyond!

assets/www/app.css
@@ -413,6 +413,7 @@ button#search
#about-license {
font-size: 10px;
+ margin-bottom: 50px;
@jdlrobson Collaborator

Should probably be added to #about-page-content instead of here

@astagi
astagi added a note

No problem :) Fixed in the next commit, thanks ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jdlrobson
Collaborator

See #186
Closing for time being but may need to use the margin-bottom trick to address bug 34170 if a better solution cannot be found
https://bugzilla.wikimedia.org/show_bug.cgi?id=34170

@jdlrobson jdlrobson closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
5 assets/www/app.css
@@ -405,6 +405,11 @@ button#search
text-align: center;
}
+#about-page-content {
+ text-align: center;
+ margin-bottom: 50px;
+}
+
#about-version {
font-size: 30px;
color: Black;
View
2  assets/www/index.html
@@ -179,7 +179,7 @@
<p id="about-contributors"></p>
<p id="about-credits-header"><msg key="about-credits"></msg></p>
<p id="about-credits"></p>
- <p id="about-license"><msg key="about-license"></msg></p>
+ <p id="about-license"></p>
</div>
</div>
</div>
View
1  assets/www/js/main.js
@@ -31,6 +31,7 @@ function aboutPage() {
$("#about-version-string").text(getAboutVersionString());
$("#about-contributors").text($.trim(authors).split('\n').join(', '));
$("#about-credits").html(window.CREDITS.join('<br />'));
+ $("#about-license").html("<br />" + mw.message("about-license"));
chrome.hideOverlays();
chrome.hideContent();
$("#about-page-overlay").localize().show();
View
2  assets/www/messages/messages-en.properties
@@ -61,7 +61,7 @@ about-close = Close about screen
about-page-title = About
about-version = Version
about-copyright = This application is copyright (C) Wikimedia Foundation and contributing developers
-about-license = This application is free software under the GNU General Public License. You are welcome to distribute and modify it under certain conditions. See http://www.gnu.org/licenses/old-licenses/gpl-2.0.html for details. The source code is available at https://github.com/Wikimedia/WikipediaMobile
+about-license = This application is free software under the GNU General Public License. You are welcome to distribute and modify it under certain conditions. See <a href="http://www.gnu.org/licenses/old-licenses/gpl-2.0.html">http://www.gnu.org/licenses/old-licenses/gpl-2.0.html</a> for details. The source code is available at <a href="https://github.com/Wikimedia/WikipediaMobile">https://github.com/Wikimedia/WikipediaMobile</a>
about-contributors = We would like to recognize the following names for their contributions to the product:
about-credits = Wikipedia Mobile builds upon many Open Source works, including:
nearby-close = Close nearby pages screen
Something went wrong with that request. Please try again.