Skip to content

Make initial page load be empty #219

Closed
wants to merge 1 commit into from

3 participants

@yuvipanda

For the beta, we're going to just make the initial page load be empty. (ref https://bugzilla.wikimedia.org/show_bug.cgi?id=36017)

@yuvipanda

Hmm, on EDGE / 3G? I would still want to have a 'start page' of sorts.

@brion
brion commented Apr 27, 2012

In theory it still shouldn't stop things from starting to work, but it probably does suck more on a slow network yes. :)

Consider also the case where we switch away from the app, say to an external link or another app, and when we switch back the app's been killed due to memory pressure and restarts. Currently we'll reload the same page, but not at the same scroll position or the same section folding state...

Ideally we should probably save the HTML from the last page view so we don't have to go reload it over the network.... but with the way things are that'll be awkward. (especially if we want the images).

Maybe let's try throwing together a startup page instead of the blank one for now; blank says "app is broken" to me.

@yuvipanda

@brion we will do that before final app release - blank is for the beta.

@jdlrobson jdlrobson commented on the diff May 1, 2012
assets/www/js/chrome.js
@@ -131,26 +131,15 @@ window.chrome = function() {
$(".closeButton").bind('click', showContent);
initContentLinkHandlers();
- chrome.loadFirstPage();
+ chrome.loadFirstPage()
@jdlrobson
jdlrobson added a note May 1, 2012

Please amend so this semicolon is not removed.

@yuvipanda
yuvipanda added a note May 1, 2012

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@jdlrobson

merged in 3d77912
However we must ensure there is some static content here before a release.

@jdlrobson jdlrobson closed this May 1, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.