Fix: should use apiTitle and language code when updating bookmark status #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -855,7 +855,8 @@ public void accept(Object event) { | |||
| return; | |||
| } | |||
| for (ReadingListPage page : ((ArticleSavedOrDeletedEvent) event).getPages()) { | |||
| if (page.title().equals(pageFragment.getTitleOriginal().getDisplayText())) { | |||
| if (page.apiTitle().equals(pageFragment.getTitleOriginal().getPrefixedText()) | |||
| && page.wiki().languageCode().equals(pageFragment.getTitleOriginal().getWikiSite().languageCode())) { | |||
There was a problem hiding this comment.
Isn't the language code check unnecessary, since it will not meet the title condition if the languages are different?
There was a problem hiding this comment.
It is necessary if the article has different language variants. They will use the same apiTitle with different language code to request the endpoints. e.g. zh-hant vs zh-hans
There was a problem hiding this comment.
Ah! ok.. makes sense..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1695
When adding an article that the
getDisplayText()is not the same as thegetPrefixedText(), the bookmark icon will not change its status correctly.e.g.
https://zh.wikipedia.org/wiki/核武器 in
zh-hantapiTitle=> 核武器displayTitle=> 核子武器