Adapt to DataValuesJavaScript 0.7.0

[snaterlicious]

No description provided.

[thiemowmde]

Almost +2, looks very good.

I tried to fix the tests. @snaterlicious, can you please have a look and tell me if this is ok? I will merge it then.

[snaterlicious]

OK, cool, thanks. Sorry for forgetting about those tests... Fine with it.

[thiemowmde]

@snaterlicious, cool, thanks.

Now this kind of depends on wmde/DataValuesJavaScript#69. Can you have a look?

[thiemowmde]

This calls toLowerCase on an object or, with the simplified CALENDARS structure, on a string URI.

[thiemowmde]

@snaterlicious, I amended my commit, adapted to the changes in wmde/DataValuesJavaScript#69 and found and fixed a small issue you missed (check the _otherCalendar var). Please have an other look and tell me if my commit is ok.

[snaterlicious]

Wasn't that because of your amendment in DataValuesJavaScript? Whatever, looks good.

[thiemowmde]

Where does a calendarModelcalendarName option come from? I think it doesn't exist and needs to be replaced with a TimeValue.getCalendarModelKeyByUri call.

[snaterlicious]

So, you did not test the pull request after your additional changes in DataValuesJavaScript? What do you expect value.getOption( 'calendarModel' ) to return being aware that value is a TimeValue object (https://github.com/wmde/DataValuesJavascript/blob/master/src/values/TimeValue.js)? If it is nor the URI, something is wrong as the call to TimeValue.getCalendarModelKeyByUri is just two lines below.

[thiemowmde]

I put the comment on the wrong line, see the calendarName option below.

[thiemowmde]

I was referring to this line. I fixed it in my commit, see 929a808#diff-49060d53e8ad9e0d74b8e4ea672589a5L53.

[filbertkm]

rebased, updating version to 0.15.0

[thiemowmde]

"DataValues JavaScript" please.

[thiemowmde]

What's the reason for the change in the version number?

[filbertkm]

when using this patch together with current versions of stuff (e.g. data values javascript), I get "Uncaught Error: Unknown dependency: dataValues.TimeValue"

thus I think this is a breaking change.

[filbertkm]

jquery.valueview.ExpertExtender.CalendarHint (or at least its tests) needs adjustments

"jquery.valueview.ExpertExtender.CalendarHint: switch switches the calendar model" and
"jquery.valueview.ExpertExtender.CalendarHint: switch twice switches the calendar model back" fail

[thiemowmde]

Right, dataValues.TimeValue did not existed in DataValues JavaScript ~0.6.0.

From semver.org: "What should I do if I update my own dependencies without changing the public API?
That would be considered compatible since it does not affect the public API. [...] Determining whether the change is a patch level or minor level modification depends on whether you updated your dependencies in order to fix a bug or introduce new functionality."

In my opinion this classifies as a bugfix.

[thiemowmde]

@filbertkm I squashed the two commits and decreased the version number to 0.14.4. Is this ok for you?