Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch pageviews asynchronously, max 100 per second #288

Merged
merged 1 commit into from Apr 16, 2019

Conversation

2 participants
@MusikAnimal
Copy link
Contributor

commented Apr 16, 2019

This only covers fetching of pageviews during a normal update.
The reports still need to be converted to be async.

PageviewsRepository::getAggregate() was removed as it is not used and
unlikely to be used in the future.

Bug: T217911

Fetch pageviews asynchronously, max 100 per second
This only covers fetching of pageviews during a normal update.
The reports still need to be converted to be async.

PageviewsRepository::getAggregate() was removed as it is not used and
unlikely to be used in the future.

Bug: T217911

@MusikAnimal MusikAnimal force-pushed the async-pageviews-1 branch from ee79f8a to 2fd6c0a Apr 16, 2019

@MusikAnimal MusikAnimal requested review from MaxSem and samwilson Apr 16, 2019

@MaxSem

MaxSem approved these changes Apr 16, 2019

@MaxSem MaxSem merged commit c79a8bc into master Apr 16, 2019

5 checks passed

Scrutinizer Analysis: 6 updated code elements – Tests: passed
Details
codeclimate 1 fixed issue
Details
codeclimate/diff-coverage 100% (50% threshold)
Details
codeclimate/total-coverage 95% (0.0% change)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@MaxSem MaxSem deleted the async-pageviews-1 branch Apr 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.