Updated RuboCop to the latest version

Populated configuration file with recommended settings and recreated
todo file.

Bug: T117987
Change-Id: I6aae658d27b7756122cba1f09ae87fd7b56b21e2

.rubocop.yml

@@ -4,3 +4,25 @@ AllCops:
   Exclude:
     - 'extensions/**/*'
     - 'vendor/**/*'
+
+AllCops:
+  StyleGuideCopsOnly: true
+
+# Uncomment when lines are under 100 lenghth
+# Metrics/LineLength:
+#   Max: 100
+
+Metrics/MethodLength:
+  Enabled: false
+
+Style/Alias:
+  Enabled: false
+
+Style/SignalException:
+  Enabled: false
+
+Style/StringLiterals:
+  EnforcedStyle: single_quotes
+
+Style/TrivialAccessors:
+  ExactNameMatch: true

.rubocop_todo.yml

@@ -1,5 +1,6 @@
-# This configuration was generated by `rubocop --auto-gen-config`
-# on 2014-10-21 16:00:13 +0200 using RuboCop version 0.26.1.
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2015-11-09 14:28:59 +0100 using RuboCop version 0.34.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -8,103 +9,92 @@
 # Offense count: 1
 # Cop supports --auto-correct.
 Lint/UnusedBlockArgument:
-  Enabled: false
+  Exclude:
+    - 'tests/browser/features/support/hooks.rb'
 
 # Offense count: 1
 Lint/UselessAssignment:
-  Enabled: false
-
-# Offense count: 3
-Lint/Void:
-  Enabled: false
-
-# Offense count: 1
-# Configuration parameters: CountComments.
-Metrics/ClassLength:
-  Max: 101
+  Exclude:
+    - 'tests/browser/features/support/pages/manage_translator_sandbox_page.rb'
 
-# Offense count: 50
+# Offense count: 48
 # Configuration parameters: AllowURI, URISchemes.
 Metrics/LineLength:
   Max: 127
 
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredMethods.
-Style/CollectionMethods:
-  Enabled: false
-
-# Offense count: 4
-Style/Documentation:
-  Enabled: false
-
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: AllowAdjacentOneLineDefs.
 Style/EmptyLineBetweenDefs:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/EmptyLinesAroundBody:
-  Enabled: false
+  Exclude:
+    - 'tests/browser/features/support/pages/stash_page.rb'
 
 # Offense count: 24
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
+# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
 Style/HashSyntax:
   Enabled: false
 
 # Offense count: 117
 # Cop supports --auto-correct.
+# Configuration parameters: Width.
 Style/IndentationWidth:
-  Enabled: false
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/LeadingCommentSpace:
-  Enabled: false
+  Exclude:
+    - 'tests/browser/features/step_definitions/manage_translator_sandbox_steps.rb'
+    - 'tests/browser/features/step_definitions/special_translate_steps.rb'
+    - 'tests/browser/features/step_definitions/translation_stash_steps.rb'
+    - 'tests/browser/features/support/hooks.rb'
+    - 'tests/browser/features/support/pages/manage_translator_sandbox_page.rb'
+    - 'tests/browser/features/support/pages/stash_page.rb'
+    - 'tests/browser/features/support/pages/translate_page.rb'
+    - 'tests/browser/features/support/pages/user_page.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 Style/Not:
-  Enabled: false
+  Exclude:
+    - 'tests/browser/features/support/pages/manage_translator_sandbox_page.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
-  Enabled: false
+  Exclude:
+    - 'tests/browser/features/support/pages/manage_translator_sandbox_page.rb'
 
 # Offense count: 2
 # Cop supports --auto-correct.
 Style/RedundantSelf:
-  Enabled: false
+  Exclude:
+    - 'tests/browser/features/support/pages/stash_page.rb'
 
 # Offense count: 14
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyleForEmptyBraces, SupportedStyles.
 Style/SpaceInsideHashLiteralBraces:
   EnforcedStyle: no_space
 
-# Offense count: 76
+# Offense count: 73
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles.
 Style/StringLiterals:
   Enabled: false
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoredMethods.
-Style/SymbolProc:
-  Enabled: false
-
-# Offense count: 250
+# Offense count: 246
 # Cop supports --auto-correct.
 Style/Tab:
-  Enabled: false
+  Exclude:
+    - 'tests/browser/features/step_definitions/manage_translator_sandbox_steps.rb'
+    - 'tests/browser/features/step_definitions/special_translate_steps.rb'
+    - 'tests/browser/features/step_definitions/translation_stash_steps.rb'
+    - 'tests/browser/features/support/hooks.rb'
+    - 'tests/browser/features/support/pages/manage_translator_sandbox_page.rb'
+    - 'tests/browser/features/support/pages/stash_page.rb'
+    - 'tests/browser/features/support/pages/translate_page.rb'
+    - 'tests/browser/features/support/pages/user_page.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.
+# Configuration parameters: WordRegex.
 Style/WordArray:
   MinSize: 5

Gemfile

@@ -1,4 +1,4 @@
 source "https://rubygems.org"
 
 gem "mediawiki_selenium", "~> 1.6.2"
-gem "rubocop", "~> 0.26.1", require: false
+gem 'rubocop', '~> 0.34.2', require: false

Gemfile.lock

@@ -59,9 +59,9 @@ GEM
       watir-webdriver (>= 0.6.11)
     page_navigation (0.9)
       data_magic (>= 0.14)
-    parser (2.3.0.pre.2)
+    parser (2.2.3.0)
       ast (>= 1.1, < 3.0)
-    powerpack (0.0.9)
+    powerpack (0.1.1)
     rainbow (2.0.0)
     rest-client (1.8.0)
       http-cookie (>= 1.0.2, < 2.0)
@@ -70,10 +70,10 @@ GEM
     rspec-core (2.99.2)
     rspec-expectations (2.99.2)
       diff-lcs (>= 1.1.3, < 2.0)
-    rubocop (0.26.1)
+    rubocop (0.34.2)
       astrolabe (~> 1.3)
-      parser (>= 2.2.0.pre.4, < 3.0)
-      powerpack (~> 0.0.6)
+      parser (>= 2.2.2.5, < 3.0)
+      powerpack (~> 0.1)
       rainbow (>= 1.99.1, < 3.0)
       ruby-progressbar (~> 1.4)
     ruby-progressbar (1.7.5)
@@ -98,4 +98,4 @@ PLATFORMS
 
 DEPENDENCIES
   mediawiki_selenium (~> 1.6.2)
-  rubocop (~> 0.26.1)
+  rubocop (~> 0.34.2)