From a8a1f50d6b7068553919e0f080a8074b8a60795c Mon Sep 17 00:00:00 2001
From: Kunal Mehta <legoktm@member.fsf.org>
Date: Sun, 23 Aug 2020 03:59:14 -0700
Subject: [PATCH] Disallow is_resource()

PHP 8.0+ is migrating away from the `resource` type in favor of normal
classes, see <https://github.com/php/php-tasks/issues/6>.

Code should generally check for return values being false rather than using
is_resource().

Bug: T260735
Change-Id: Iad84a60b302b22497f7ec1282e4e6223a32ebaeb
---
 MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php b/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
index 3b0c42d..9504a6a 100644
--- a/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
+++ b/MediaWiki/Sniffs/Usage/ForbiddenFunctionsSniff.php
@@ -58,6 +58,8 @@ class ForbiddenFunctionsSniff implements Sniff {
 		'shell_exec' => false,
 		'system' => false,
 		'isset' => false,
+		// resource type is going away in PHP 8.0+ (T260735)
+		'is_resource' => false,
 	];
 
 	/**