Fix tests on HHVM #20
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fredemmott
commented
Mar 7, 2014
fredemmott
commented
- Fix old dates - bad test data (see Correct day of week for old test dates #19 )
- Remove ini_set('precision') - unsupported in HHVM, and irrelevant as the test is not dealing with floats.
|
Unfortunately, the build failed. Also, Github is not where we do our code review (it's simply a mirror), please see https://www.mediawiki.org/wiki/Gerrit |
|
@Krenair: thanks, I'll re-submit there once Travis updates to a more recent version of HHVM. The build fails because the tests are bad, and HHVM 2.4.0 (which travis has) has the same bad behavior. This diff corrects the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.