Commits on May 26, 2017
  1. Moving setting env properties closer to where they're used

    Change-Id: I3496ab7668c48f93d1a98baccdb1b5caf7ea0327
    arlolra committed with jenkins-bot May 25, 2017
  2. T161151: Use already resolved href when available

     * Avoids trying to resolve titles potentially containing template
    Change-Id: I5a62052fb5ec800f169de687beb8ab3edc3af67e
    arlolra committed May 25, 2017
Commits on May 25, 2017
  1. Don't modify passed in apiConf

     * It prevents reuse of parsoidOptions, relevant to an upcoming patch.
    Change-Id: Ic27f1e0feba0ae5c3e172d70f0b4c2d6ec079ca2
    arlolra committed May 25, 2017
Commits on May 24, 2017
  1. Stop using usePHPPreProcessor as a proxy for an existing mw api to pa…

    …rse extensions
     * We already have expandExtensions to control that similarly to
       fetchImageInfo and others.
     * A lot of the removed code in the mock api is old / obsolete from
     * This also includes a fix so that non-native self-closed extensions
     * Finally, s/usephppreprocessor/usePHPPreProcessor/ for the command
       line argument since we use camelCase in all the others.
    Change-Id: Idc1bf660d83b7b876c7332008523651534c23962
    arlolra committed May 22, 2017
Commits on May 19, 2017
  1. Fix crasher introduced in d722f89

     * The old code would send, say, {{デフォルトソート:あきやま とくそう}}
       off for expansion, which would return
       {{DEFAULTSORT:あきやまとくそう}}.  This time around,
       resolveTemplateTarget would recognize that as a masquerading
       magicWordType and do the expected thing.
     * The new code determines beforehand that it's a masq, and so must
       provide the canonical name to be added as the page property.  If not,
       by the time we get to the tree builder, the token is expected to have
       typeof and crashes without it.
    Change-Id: Ia2035f3eb26f2bb8a24d2bde5fe9f4a1c6c755d6
    arlolra committed May 19, 2017
  2. T115395: Run parsertests with the batch api enabled

    Change-Id: I892117d745094b6a5f19695f385de3956f0780f6
    arlolra committed May 19, 2017
Commits on May 18, 2017
  1. Remove dependence on native parser functions

     * The path in resolveTemplateTarget should not depend on the existence
       of the arbitrary parser functions that we've natively defined.
    Change-Id: Id34b1172f8be42e5dc2fc7fb4f165f84714b5b80
    arlolra committed May 17, 2017
Commits on May 17, 2017
  1. Sync baseconfigs

    Change-Id: I622a7e20696001458c4aae27c8479084acb7cb78
    arlolra committed May 17, 2017
  2. Only skip to the phase end in native template expansion

     * When loop / depth detection mechanism is triggered.
     * Follow up to 60ee19a
    Change-Id: I40b65bb48f969b93bf759f33bed2d3376cf3bfe8
    arlolra committed May 16, 2017
Commits on May 12, 2017
  1. T141226: Fix logic when unpacking dom fragments

     * We've cached the previous sibling, we need to return to its adjacent
       node when starting to process migrated children.
    Change-Id: I14c3b696917ef1396e8b9362bdece3f1febdbeeb
    arlolra committed May 12, 2017
  2. Remove some extraneous nesting in domfragment unpacker

    Change-Id: Id92d39421123219bdc2a649a48e11dbf6fcb3c2f
    arlolra committed May 12, 2017
  3. Add an API endpoint to get lint errors for wikitext

     * Arbitrary wikitext is supported by POST requests to the
       /transform/wikitext/to/lint/ endpoint.
     * Fetching lint errors for specific revisions can also by supported at
       that endpoint by omitting the wikitext and supplying a title, and
       optional revision number.
    Bug: T163091
    Bug: T164006
    Change-Id: I50837e66b65837e33955e1b99cc2b8f495d6e131
    arlolra committed May 8, 2017
  4. Assert valid get formats in http api

    Change-Id: I8c1f48404029a9bfcd2db863295c092c20799eb6
    arlolra committed May 11, 2017
Commits on May 11, 2017
  1. T115395: Mock the batch api

     * Enabled in the mocha http api tests, which make at least one
       preprocessor request at the moment.
    Change-Id: I0383c38cffb8b9cf37b72df87f60e216938906fb
    arlolra committed with jenkins-bot May 11, 2017
  2. Return to previous modified state

     * Probably doesn't make a difference because we don't have nested
       inserted content.
    Change-Id: I62795cedf30526a7b91120306bd932b893bc3736
    arlolra committed with jenkins-bot May 10, 2017
Commits on May 9, 2017
  1. Run tests based on config.yaml instead of localsettings.js

     * Also, move requiring of localsettings file inside ParsoidConfig so it
       can be tested.
    Change-Id: Ic6f4d3cae24cd660a1b9bfcc3e8800b9ca8ea165
    arlolra committed May 5, 2017
Commits on May 8, 2017
  1. Assert valid transformations between formats in the http api

    Change-Id: Ib3baa70d90b6554bebe857478b22d1f168b58ed6
    arlolra committed May 8, 2017
  2. T163549: Only lint pages that have wikitext contentmodel

    Change-Id: I540429cd110e69c4cbf451b918c1f64931caa213
    arlolra committed May 8, 2017
  3. Fix typo introduced in f051b26

    Change-Id: Iec153aea6809c74fdbee87f622d3fb16af4f03d8
    arlolra committed with jenkins-bot May 8, 2017
Commits on May 5, 2017
  1. Remove support for pb2html in the http api

     * There doesn't appear to be a need for this and it adds unnecessary
       complications, especially in downgrading.
     * The html produced in wt2html, as opposed to wt2pb, is different in
       that data-parsoid is inlined.  Using the wt2pb html to produce that
       type of html runs afoul when trying to determine which ids are safe
       to remove.
    Change-Id: Id020cbc0204bd390b5468192574b03a39752ba00
    arlolra committed May 4, 2017
Commits on May 3, 2017
  1. Reduce some redundancy in _requestInfoAndRenderLink

    Change-Id: I6b27188610b744c99e124a0ee33b45d996600c61
    arlolra committed May 3, 2017
Commits on Apr 27, 2017
  1. [eslint] Enforce lines-around-directive

     * Done with --fix
    Change-Id: Ie9b34c69615493870427be5f318a14f31a361d6a
    arlolra committed Apr 27, 2017
  2. [eslint] Use eslint-config-node-services

     * Lots of overrides here that we should either fix or be explicit about
       wanting to diverge and maybe talk about upstreaming the change.
    Change-Id: I927dd325e49ef72ccbe5e8b926f7984b82dd0f2e
    arlolra committed Apr 27, 2017
  3. [eslint] Enforce object-curly-spacing

     * Done with --fix
    Change-Id: Ic03f1fd783068c3e1cc39e49f8cfc7755d44fe6c
    arlolra committed Apr 27, 2017
  4. T163744: Switch to eslint

     * .eslintrc was generated from .jshintrc and .jscsrc using polyjuice
       and some manual tweaking.
     * Forced to follow the convention in eslint #4174
     * However, in a follow up, we'll use wikimedia/eslint-config-node-services
    Change-Id: I2500a6520a5c9f41d5333e937c151228aec88be0
    arlolra committed Apr 25, 2017
Commits on Apr 26, 2017
  1. T116508: Remove .mw-body from Parsoid content

     * Since T155863, all the relevant styles are on .mw-body-content
     * A new class .parsoid-body was created in Vector to just apply the
       desired layout.  See I60e3cb3e838fa19d321c4eac0a6828bcfddb6f3e
    Change-Id: Id41c1d2840f441eddb14ca66ba545ee7b160088e
    arlolra committed with jenkins-bot Apr 11, 2017
  2. Bump the content version to 1.4.0 for a/v

     * Updated spec at
    Change-Id: I3b237150c5baf7eff273679799c5a6cf56dd5da1
    arlolra committed Apr 26, 2017
Commits on Apr 25, 2017
  1. Remove advanced PDoc usage from the jsapi

     * This now lives here:
    Change-Id: I03c089c68e8a9639b9ca775dd74fed75b25db5c4
    arlolra committed with jenkins-bot Apr 13, 2017
  2. Ignore nsp advisory for brace-expansion

     * It's a dep of an optional dep that we don't even install.
     * For now, at least, until new releases are available upstream.
    Change-Id: Ib6afd492000ef47ed4aad57dae276e7175b18bec
    arlolra committed Apr 25, 2017
  3. T133673: Set default dimensions for audio files

     * Follow up to b05fcc3.
     * This sets a fixed height and configurable width, as in TimedMediaHandler.
     * Consequently, fixes the roundtrip diffs when upright is specified on
       audio files, since that option is ignored when serializing if the
       dimensions are modified, and by not adding a height, we were forcing
       that to true.
       For example, see /
    Change-Id: Ia735ceb3f1373ba703e736ad67da058737cd2e4b
    arlolra committed with jenkins-bot Apr 24, 2017
Commits on Apr 24, 2017
  1. Fix crasher from a9cfa9c

     * On /फर्डिनैंड_कोह्न/2674115
     * Ignoring subst came from aaca5ea but doesn't seem right.  However,
       we should be ignoring safesubt, since that's designed to work when
    Change-Id: Ia15c4e1aa36d13ea0d25870e47f6248ca297066d
    arlolra committed with jenkins-bot Apr 24, 2017
Commits on Apr 21, 2017
  1. T64270: Support video and audio content

     * Spec'd at
    Depends-On: Icb26ffb802150c1d1f8c6e0aab05b25e503077e2
    Change-Id: I53c6fa8d862c152bb1c8dd3ae96f4ee464a60d32
    arlolra committed with jenkins-bot Feb 2, 2017
  2. Factor out common encapsulation pattern

    Change-Id: I564e3a9d40b0ead088d37c87a47015069cb4a938
    arlolra committed Apr 21, 2017
Commits on Apr 20, 2017
  1. T154709: Honour the "page" option for files

     * Fixes rendering and roundtripping.
    Change-Id: I35c6d6896495ee744a3d2331b9cec902ab139667
    arlolra committed Mar 9, 2017
Commits on Apr 19, 2017
  1. T89262: Read thumb sizes from siteinfo

    Change-Id: Iae140d71aeefbab73f0626fa39d9efebf82328e1
    arlolra committed with jenkins-bot Mar 3, 2017