Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a previously aborted task make the field not green #126

Open
Luke081515 opened this issue May 29, 2016 · 4 comments
Open

Saving a previously aborted task make the field not green #126

Luke081515 opened this issue May 29, 2016 · 4 comments

Comments

@Luke081515
Copy link

Luke081515 commented May 29, 2016

  1. Abbort the rating of a diff
  2. Click now above into the header to see this diff again
  3. Rate him
  4. The field stays red.
@Ladsgroup
Copy link
Member

Hey, It's something by design. I'm not sure if we need to change that or not. @halfak. Any comments?

@Pix1234
Copy link
Collaborator

Pix1234 commented Jun 25, 2017

Is this still relevent? If so i will close this and move it to phab

@halfak
Copy link
Member

halfak commented Jun 26, 2017

Hmm.. I think the real issue is that the UI allows you to submit a label for a task that is no longer in your workset. We should probably disable the form entirely when the a task has been abandoned.

@he7d3r
Copy link
Contributor

he7d3r commented Apr 14, 2020

I just tested this, and I confirm I was able to submit a label after I changed my mind and clicked on a red/abandoned task from my workset. However, the abandoned task disappears from my workset once I reload the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants