Don’t adjust font size of password field on login #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes a bug in iOS 10, where setting resize-to-fit text on a secure text field causes the app to hang, peak memory, and eventually crash bug: https://phabricator.wikimedia.org/T150982 radar: https://openradar.appspot.com/28590124
coreyfloyd
approved these changes
Nov 21, 2016
|
Thanks for the fix! |
|
Happy to help! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey folks!
This patch fixes a bug in iOS 10, where setting resize-to-fit text on a secure text field causes the app to hang, peak memory, and eventually crash.
To fix it I just disabled the resizing. To me, since in secure text fields you can't see the actual characters anyways, there doesn't seem to be much harm in turning off the resizing, but let me know if there something else you'd want to do instead!
bug: https://phabricator.wikimedia.org/T150982
radar: https://openradar.appspot.com/28590124
Before patch
After patch