Search messages #122
Merged
Search messages #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Shows "no results found" and server error messages as alerts. That way, if a user searches for a term which doesn't produce results, or if there are network connectivity issues, the user will get an indication of what happened.
Current coverage is
|
|
looks good! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.wikimedia.org/T104858
Temporarily show old-style alerts for search until we can restyle alerts.
Show alert when no search results were found:
Show alert relaying any error messages, such as connectivity problems:
(this should also cause the "Search is currently too busy. Please try again later." message from the phab ticket to be shown properly)