Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #3328

Merged
merged 4 commits into from Nov 14, 2019

Conversation

@jhsoby
Copy link
Contributor

jhsoby commented Nov 13, 2019

Thanks was set to » Thanks was sent to

Reported by @papuass in https://translatewiki.net/wiki/Thread:Support/Reporting_typo_in_source

Fix typo
Thanks was set to » Thanks was se**n**t to
@montehurd

This comment has been minimized.

Copy link
Contributor

montehurd commented Nov 13, 2019

Oh good catch!

Looks like you'll need to change it here too:
https://github.com/wikimedia/wikipedia-ios/blob/develop/Wikipedia/Code/DiffContainerViewController.swift#L672

(Wikipedia/Localizations/en.lproj/Localizable.strings is auto-generated upon project build from LocalizedString calls like the one seen on that line)

@jhsoby

This comment has been minimized.

Copy link
Contributor Author

jhsoby commented Nov 13, 2019

{{done}}

@nambatee nambatee added the Low Impact label Nov 14, 2019
nambatee and others added 2 commits Nov 14, 2019
@joewalsh joewalsh merged commit 24df002 into wikimedia:develop Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.