Add pull requests info to Test Flight

[mcleinman]

Fixes Phabricator ticket: (N/A, was a request in a meeting)

Notes

• Include info about PRs in our TestFlight notes. This is most useful for internal testing.
• Hopefully this doesn't have the same issues that our automated version did (which we eventually commented out): https://github.com/wikimedia/wikipedia-ios/pull/2005/files

Test Steps

1. N/A - will test w/ next beta (going out tomorrow, likely)

Screenshots/Videos

Release notes look like this:

____New since last build (betas/1814)____
None

____New since last public release (releases/6.8.0)____
3c00909857 - https://github.com/wikimedia/wikipedia-ios/pull/3943 from wikimedia/T282189
8f30c8dc9b - https://github.com/wikimedia/wikipedia-ios/pull/3946 from wikimedia/T269042-follow-up
0924c07672 - https://github.com/wikimedia/wikipedia-ios/pull/3944 from wikimedia/T269042
dc13ad31d7 - https://github.com/wikimedia/wikipedia-ios/pull/3937 from wikimedia/T280739
310f7554e6 - https://github.com/wikimedia/wikipedia-ios/pull/3945 from wikimedia/twn
7c592ec1d4 - https://github.com/wikimedia/wikipedia-ios/pull/3940 from wikimedia/DuplicateNorwegian
63d12f6065 - https://github.com/wikimedia/wikipedia-ios/pull/3941 from wikimedia/T258211
12e4f43c9a - https://github.com/wikimedia/wikipedia-ios/pull/3942 from wikimedia/twn
b9b6153e26 - https://github.com/wikimedia/wikipedia-ios/pull/3938 from wikimedia/T255490
38aed01956 - https://github.com/wikimedia/wikipedia-ios/pull/3936 from wikimedia/RTLForVariants
0d38c09e06 - https://github.com/wikimedia/wikipedia-ios/pull/3939 from amire80/not-translation
050e256def - https://github.com/wikimedia/wikipedia-ios/pull/3933 from wikimedia/T277066
f3068fff83 - https://github.com/wikimedia/wikipedia-ios/pull/3935 from wikimedia/T280838
1bfefd4378 - https://github.com/wikimedia/wikipedia-ios/pull/3929 from wikimedia/T249056
bc96ab1a8b - https://github.com/wikimedia/wikipedia-ios/pull/3930 from wikimedia/RemoveUnneededSearchLookup
4952fdb883 - https://github.com/wikimedia/wikipedia-ios/pull/3932 from wikimedia/twn
0d6f997a4d - https://github.com/wikimedia/wikipedia-ios/pull/3931 from wikimedia/twn
44e9708853 - https://github.com/wikimedia/wikipedia-ios/pull/3928 from wikimedia/xcode-12.5-updates
6d01ad0576 - https://github.com/wikimedia/wikipedia-ios/pull/3924 from wikimedia/release_tag
569cce2311 - https://github.com/wikimedia/wikipedia-ios/pull/3927 from wikimedia/RemoveISOCodeCheck
e63b31eef0 - https://github.com/wikimedia/wikipedia-ios/pull/3920 from wikimedia/checker-fixes
f72c2aa205 - https://github.com/wikimedia/wikipedia-ios/pull/3925 from wikimedia/T269479-2
33d18b9a14 - https://github.com/wikimedia/wikipedia-ios/pull/3926 from wikimedia/twn
a6a721d137 - https://github.com/wikimedia/wikipedia-ios/pull/3923 from wikimedia/T277786
407803a180 - https://github.com/wikimedia/wikipedia-ios/pull/3921 from wikimedia/RemoveVariantsFlag
dd21785fe8 - https://github.com/wikimedia/wikipedia-ios/pull/3922 from wikimedia/twn
bd69324da2 - https://github.com/wikimedia/wikipedia-ios/pull/3917 from wikimedia/wmf_LanguageRename
ba905f04e4 - https://github.com/wikimedia/wikipedia-ios/pull/3915 from wikimedia/add-tyap

[tonisevener]

FYI this is the same description as the next lane on line 192. Could we also add a "This is very similar to..." sentence to one of these to differentiate?

[mcleinman]

Updated, thanks.

[staykids]

Ignore if this is out of scope, but would it provide more value if we pulled the per merge commit messages into the change messages instead of the PR URL?

So for example from:
3c00909857 - https://github.com/wikimedia/wikipedia-ios/pull/3943 from wikimedia/T282189
to something like:
3c00909857 - #3943 Loosen AaaLD test/control assignment survey identifiers (wikimedia/T282189)

Since we're generally pretty good about naming our PRs, and since the PR number is included, I think it provides more direct value in the release notes without losing the important information and without extra cruft.

[mcleinman]

New commit message style:

0b63499a66 - Localisation updates from https://translatewiki.net. (#3953 from wikimedia/twn)
dc8db8b954 - Clean up README.md. (#3950 from wikimedia/readme-cleanup)
34b8dcdff6 - Localisation updates from https://translatewiki.net. (#3951 from wikimedia/twn)
7baac5e815 - Remove dependency named "danger" (#3947 from wikimedia/T278879)
ed4e8ce6c5 - Update pull request template. (#3949 from wikimedia/pr-template-update)
3c00909857 - Loosen AaaLD test/control assignment survey identifiers (#3943 from wikimedia/T282189)
8f30c8dc9b - Remove unused `showEmailFeedbackAlertViewWithError` method. (#3946 from wikimedia/T269042-follow-up)

@staykids - I think this is almost what you asked for. The commit message formatted like Merge pull request #3942 from wikimedia/twn as one string, and I don't see another way to get the merge branch from git log. Thus, it's a lot easier if we keep the PR number and the branch near each other. It's of course possible to separate the PR number from the branch in our script, but it doesn't seem worth the codesmell to me. That said, if you think it's worth it, let me know - I'll happily adjust this further.

[tonisevener]

I made a couple of small changes, but I'm happy to revert in a follow on PR if we need to:

1. I think the change from, {#start} to betas/1808 made in cf5dd6 was just some testing code that snuck in, so I reverted that.
2. I noticed some non-PR merge commits like "(Merge branch 'main' into improve_release_notes)" which muddied the list, so I'm filtering commits like that out in the git log command.

[mcleinman]

@tonisevener Thanks for those. Perfect catch on that testing cod, and thanks for fixing those non-PR merge commits.