Some edit reverted notification cleanup #4017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonisevener
requested review from
a team and
staykids
and removed request for
a team
tonisevener
added
the
Dependent PR
- remove category and actions setup, will add back later - remove local notification scheduling for edit reverted - remove category validation when adding to database
staykids
approved these changes
Sep 13, 2021
| let modelChange = RemoteNotificationsModelChange(type: modelChangeType, notificationsGroupedByCategoryNumber: notificationsGroupedByCategoryNumber) | ||
| let responseCoordinator = RemoteNotificationsModelChangeResponseCoordinator(modelChange: modelChange, modelController: self) | ||
| DispatchQueue.main.async { | ||
| NotificationCenter.default.post(name: RemoteNotificationsModelController.modelDidChangeNotification, object: responseCoordinator) |
There was a problem hiding this comment.
Apologies if I'm missing its usage in the subsequent PRs, but would it also make sense to remove line 45 which no longer appears to be used?
There was a problem hiding this comment.
Nice catch! I pushed a commit removing this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phabricator: https://phabricator.wikimedia.org/T287298
Notes
This is part one of many for T287298. This task is just some early code cleanup I decided to do before digging into the RemoteNotifications database work. From this point forward I think it would be easier if we thought of edit reverted holistically with the other notification types than tiptoeing around this code. It also removes local notification scheduling for edit revert.
After review, please wait for #4013 to be reviewed and merged. Then update this with feature/notifications and merge.
Test Steps
Nothing major to test for now, just confirm it builds and runs.