Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EAN13 Barcode only works in Portrait #5

Closed
epha opened this issue Nov 20, 2012 · 5 comments
Closed

EAN13 Barcode only works in Portrait #5

epha opened this issue Nov 20, 2012 · 5 comments

Comments

@ghost
Copy link

@ghost ghost commented Nov 20, 2012

On iPhone iOS6.0 the scanning of the ean13 barcode only works in portrait mode. The red line has to be vertical, which is kind of unintuitive.

@ghost
Copy link

@ghost ghost commented Dec 7, 2012

I have the same issue with phonegap build using phonegap 2.1.0 and iOS6. All the testers report that the barcode scanning does not work, because they try to have the red line crossing the barcode horizontaly. I discovered that the red bar needs to be vertical only by accident.

Here's what I have in config.xml:

gap:plugin name="BarcodeScanner"
preference name="phonegap-version" value="2.1.0"

Is something else needed to have the red bar correctly oriented?

Thank you,

Stephane

@wildabeast
Copy link
Owner

@wildabeast wildabeast commented Dec 11, 2012

I think this issue was introduced when the plugin was updated to lock its orientation. Going to investigate asap. Sorry for the delayed response, was on vacation.

@ghost
Copy link
Author

@ghost ghost commented Dec 12, 2012

Yes, probably. The red line is disturbing. If orientation does not matter
anymore, could you remove the red-line and make the green rectangle a
little bigger. It would look much nicer.

Von: Ryan Willoughby [mailto:notifications@github.com]
Gesendet: Tuesday, December 11, 2012 08:57 PM
An: wildabeast/BarcodeScanner
Cc: Marco Egbring
Betreff: Re: [BarcodeScanner] EAN13 Barcode only works in Portrait (#5)

I think this issue was introduced when the plugin was updated to lock its
orientation. Going to investigate asap. Sorry for the delayed response, was
on vacation.


Reply to this email directly or view it on
GitHubhttps://github.com//issues/5#issuecomment-11259800.

@wildabeast
Copy link
Owner

@wildabeast wildabeast commented Dec 12, 2012

After going back to the original community plugin at https://github.com/phonegap/phonegap-plugins/tree/master/iOS/BarcodeScanner, it looks like linear (i.e. ean13) barcodes aren't supported in landscape. I've created an issue: https://github.com/phonegap/phonegap-plugins/issues/941.

Going to change the plugin here to lock to portrait instead for now. This ensures all barcodes are scannable and the device can be re-oriented to whichever direction linear barcodes are in. Then we can investigate support for linear barcodes in landscape in the above issue.

@wildabeast
Copy link
Owner

@wildabeast wildabeast commented Dec 21, 2012

This has now been locked to portrait, and EAN13 barcodes scan as expected.

@wildabeast wildabeast closed this Dec 21, 2012
wildabeast pushed a commit that referenced this issue Aug 11, 2015
Remove cordova.define & update ID for npm move
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.