Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ELY-1826] Cannot connect to management interface with Java Security Manager enabled #1293

Merged
merged 1 commit into from Jun 6, 2019

Conversation

ivassile
Copy link
Contributor

@ivassile ivassile commented Jun 6, 2019

JBEAP(7.2.z): https://issues.jboss.org/browse/JBEAP-17004
Upstream issue: https://issues.jboss.org/browse/ELY-1826
This issue has been resolved upstream as part of refactoring in commit [1].

[1] 2cfa1c6#diff-9ad62980379a45e80f38d71d338c2878

@fjuma
Copy link
Contributor

fjuma commented Jun 6, 2019

@ivassile Thanks for the PR! Just a minor comment, the title and commit message should reference an ELY issue instead of a JBEAP issue.

@ivassile
Copy link
Contributor Author

ivassile commented Jun 6, 2019

@fjuma I know about this rule, but we don't have specific upstream issue for the downstream issue JBEAP-17004. That's why I explained that upstream is not required and the upstream commit was part of refactoring (ELY-1711) unrelated to that issue.

darranl
darranl previously requested changes Jun 6, 2019
Copy link
Contributor

@darranl darranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good but I also think +1 to getting an ELY issue - it will just be resolved against the 1.6 release so we have accurate Elytron release notes for each release.

@ivassile ivassile changed the title [JBEAP-17004] Cannot connect to management interface with Java Security Manager enabled [ELY-1826] Cannot connect to management interface with Java Security Manager enabled Jun 6, 2019
@ivassile
Copy link
Contributor Author

ivassile commented Jun 6, 2019

Created upstream ELY-1826 and updated the description.

@fjuma
Copy link
Contributor

fjuma commented Jun 6, 2019

Perfect, thanks @ivassile! Just need the commit message updated to reference ELY-1826 and then this will be ready to be merged.

@ivassile
Copy link
Contributor Author

ivassile commented Jun 6, 2019

@fjuma Modified the commit message.

@wildfly-ci
Copy link

Linux Build 2402 outcome was FAILURE using a merge of 284f963
Summary: Tests failed: 1 (1 new), passed: 987, ignored: 9 Build time: 00:05:21

Failed tests

org.wildfly.security.x500.cert.acme.AcmeClientSpiTest.testObtainCertificateChain: org.wildfly.security.x500.cert.acme.AcmeException: ELY10038: Unexpected HTTP status code in response from ACME server "404": "Not Found"
	at org.wildfly.security.x500.cert.acme.AcmeClientSpi.handleAcmeErrorResponse(AcmeClientSpi.java:925)
	at org.wildfly.security.x500.cert.acme.AcmeClientSpi.sendGetRequest(AcmeClientSpi.java:727)
	at org.wildfly.security.x500.cert.acme.AcmeClientSpi.getResourceUrls(AcmeClientSpi.java:184)
	at org.wildfly.security.x500.cert.acme.AcmeClientSpi.getResourceUrl(AcmeClientSpi.java:710)
	at org.wildfly.security.x500.cert.acme.AcmeClientSpi.obtainCertificateChain(AcmeClientSpi.java:436)
	at org.wildfly.security.x500.cert.acme.AcmeClientSpiTest.obtainCertificateChain(AcmeClientSpiTest.java:298)
	at org.wildfly.security.x500.cert.acme.AcmeClientSpiTest.testObtainCertificateChain(AcmeClientSpiTest.java:266)
------- Stdout: -------
08:25:29,792 INFO  (nioEventLoopGroup-4-16) [org.mockserver.mock.HttpStateHandler] <MockServerLogger.java:107> resetting all expectations and request logs
08:25:29,803 INFO  (nioEventLoopGroup-4-17) [org.mockserver.mock.HttpStateHandler] <MockServerLogger.java:107> creating expectation:

	{
	  "httpRequest" : {
	    "method" : "GET",
	    "path" : "/directory"
	  },
	  "times" : {
	    "remainingTimes" : 1
	  },
	  "timeToLive" : {
	    "unlimited" : true
	  },
	  "httpResponse" : {
	    "headers" : {
	      "Cache-Control" : [ "public, max-age=0, no-cache" ],
	      "Content-Type" : [ "application/json" ]
	    },
	    "body" : "{\n  \"hb7nxeqSiSo\": \"https://community.letsencrypt.org/t/adding-random-entries-to-the-directory/33417\",\n  \"keyChange\": \"http://localhost:4001/acme/key-change\",\n  \"meta\": {\n    \"caaIdentities\": [\n      \"happy-hacker-ca.invalid\"\n    ],\n    \"termsOfService\": \"https://boulder:4431/terms/v7\",\n    \"website\": \"https://github.com/letsencrypt/boulder\"\n  },\n  \"newAccount\": \"http://localhost:4001/acme/new-acct\",\n  \"newNonce\": \"http://localhost:4001/acme/new-nonce\",\n  \"newOrder\": \"http://localhost:4001/acme/new-order\",\n  \"revokeCert\": \"http://localhost:4001/acme/revoke-cert\"\n}\n"
	  }
	}

08:25:29,814 INFO  (nioEventLoopGroup-4-18) [org.mockserver.mock.HttpStateHandler] <MockServerLogger.java:107> creating expectation:

	{
	  "httpRequest" : {
	    "method" : "HEAD",
	    "path" : "/acme/new-nonce"
	  },
	  "times" : {
	    "remainingTimes" : 1
	  },
	  "timeToLive" : {
	    "unlimited" : true
	  },
	  "httpResponse" : {
	    "statusCode" : 204,
	    "headers" : {
	      "Cache-Control" : [ "public, max-age=0, no-cache" ],
	      "Replay-Nonce" : [ "eV3KvqTuyA_bAaCZJ9ZgdQISvgGiNB_306WG1hf6qXk" ]
	    }


@fjuma fjuma dismissed darranl’s stale review June 6, 2019 17:51

ELY issue created.

@fjuma fjuma merged commit c99c4d7 into wildfly-security:1.6.x Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants