New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ELY-1826] Cannot connect to management interface with Java Security Manager enabled #1293
Conversation
@ivassile Thanks for the PR! Just a minor comment, the title and commit message should reference an ELY issue instead of a JBEAP issue. |
@fjuma I know about this rule, but we don't have specific upstream issue for the downstream issue JBEAP-17004. That's why I explained that upstream is not required and the upstream commit was part of refactoring (ELY-1711) unrelated to that issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but I also think +1 to getting an ELY issue - it will just be resolved against the 1.6 release so we have accurate Elytron release notes for each release.
Created upstream ELY-1826 and updated the description. |
Perfect, thanks @ivassile! Just need the commit message updated to reference ELY-1826 and then this will be ready to be merged. |
@fjuma Modified the commit message. |
Linux Build 2402 outcome was FAILURE using a merge of 284f963 Failed tests
|
JBEAP(7.2.z): https://issues.jboss.org/browse/JBEAP-17004
Upstream issue: https://issues.jboss.org/browse/ELY-1826
This issue has been resolved upstream as part of refactoring in commit [1].
[1] 2cfa1c6#diff-9ad62980379a45e80f38d71d338c2878