This repository has been archived by the owner on Jun 7, 2021. It is now read-only.
SWARM-990: Sub Module classes not in right location #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- RuntimeDeployer assumes all paths that are dependencies are JAR files as it calls `depContainer.addAsLibrary()` for them. However, sometimes the dependency path points to the /classes directory of another module. This is especially true when running from the IDE and it has auto added sub modules as a project dependency and not an artifact one. Modifications ------------- Get smarter about whether we're dealing with an actual library or a path to compiled classes, and handle them appropriately. Result ------ Fixes problem of /classes not being added correctly for a sub module when running in the IDE.
bobmcwhirter
approved these changes
Jan 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mvn clean install?Motivation
RuntimeDeployer assumes all paths that are dependencies are JAR files as it calls
depContainer.addAsLibrary()for them.However, sometimes the dependency path points to the /classes directory of another module. This is especially true when running from the IDE and it has auto added sub modules as a project dependency and not an artifact one.
Modifications
Get smarter about whether we're dealing with an actual library or a path to compiled classes, and handle them appropriately.
Result
Fixes problem of /classes not being added correctly for a sub module when running in the IDE.