Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSet Automatic-Module-Name and fix maven-enforcer-plugin problem #59
Conversation
… enforced with modern JDKs. Adds an Automatic-Module-Name of org.jboss.jandex to the jar META-INF/MANIFEST.MF file. Signed-off-by: Laird Nelson <ljnelson@gmail.com>
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR. I think this is reasonable. FWIW I think it's unlikely that Jandex will ever utilize Java modules beyond this. It supports pre Java 9 vms (as far back as Java 6), and for Java 9+ we also wish to support common classpath usage. While you can add a modules descriptor and let it be ignored, that also means that any security or isolation is also ignored, so it's best to just rely on package security. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ljnelson commentedApr 9, 2019
This PR bumps the version of the maven-enforcer-plugin so that it can cope with the version strings of modern JDKs and won't exit with an
ExceptionInInitializerErrorwhen invoked. It also sets anAutomatic-Module-Namein theMETA-INF/MANIFEST.MFfile. I followed the module naming guidelines referenced by Stephen Coleburne here: https://blog.joda.org/2017/04/java-se-9-jpms-module-naming.htmlThis is obviously a stopgap measure until this library can be truly modularized but it at least "claims" the module name with no compatibility issues.
Signed-off-by: Laird Nelson ljnelson@gmail.com