Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Automatic-Module-Name and fix maven-enforcer-plugin problem #59

Merged
merged 1 commit into from Mar 19, 2020

Conversation

@ljnelson
Copy link
Contributor

ljnelson commented Apr 9, 2019

This PR bumps the version of the maven-enforcer-plugin so that it can cope with the version strings of modern JDKs and won't exit with an ExceptionInInitializerError when invoked. It also sets an Automatic-Module-Name in the META-INF/MANIFEST.MF file. I followed the module naming guidelines referenced by Stephen Coleburne here: https://blog.joda.org/2017/04/java-se-9-jpms-module-naming.html

This is obviously a stopgap measure until this library can be truly modularized but it at least "claims" the module name with no compatibility issues.

Signed-off-by: Laird Nelson ljnelson@gmail.com

… enforced with modern JDKs. Adds an Automatic-Module-Name of org.jboss.jandex to the jar META-INF/MANIFEST.MF file.

Signed-off-by: Laird Nelson <ljnelson@gmail.com>
@n1hility

This comment has been minimized.

Copy link
Contributor

n1hility commented Mar 19, 2020

Thanks for the PR. I think this is reasonable.

FWIW I think it's unlikely that Jandex will ever utilize Java modules beyond this. It supports pre Java 9 vms (as far back as Java 6), and for Java 9+ we also wish to support common classpath usage. While you can add a modules descriptor and let it be ignored, that also means that any security or isolation is also ignored, so it's best to just rely on package security.

@n1hility n1hility merged commit 70fcd76 into wildfly:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.