Skip to content
Permalink
Browse files

[WFCORE-4061] remove redundant else clause because attribute name sho…

…uld have been validated before execution.
  • Loading branch information
soul2zimate committed Aug 27, 2018
1 parent 9009338 commit 14a2e5a10af43f9cf27de16bbfc5a1c7517f65d4
@@ -99,14 +99,11 @@ public void execute(OperationContext context, ModelNode operation) throws Operat
final String attribute = operation.require(NAME).asString();
final ApplicationTypeConfigResource resource = (ApplicationTypeConfigResource)context.readResource(PathAddress.EMPTY_ADDRESS);
final ApplicationTypeConfig applicationType = resource.applicationType;
Boolean result;
Boolean result = null;
if (attribute.equals(DEFAULT_APPLICATION.getName())) {
result = applicationType.isDefaultApplication();
} else if (attribute.equals(CONFIGURED_APPLICATION.getName())) {
result = applicationType.getConfiguredApplication();
} else {
//TODO i18n
throw new IllegalStateException();
}

context.getResult();
@@ -127,17 +124,10 @@ public void execute(OperationContext context, ModelNode operation) throws Operat
// record model values for rollback handler
ModelNode configuredApplication = modelNode.get(ModelDescriptionConstants.CONFIGURED_APPLICATION);

final String attribute = operation.require(NAME).asString();
final ModelNode value = operation.require(VALUE);
final ApplicationTypeConfigResource resource = (ApplicationTypeConfigResource)context.readResourceForUpdate(PathAddress.EMPTY_ADDRESS);
final ApplicationTypeConfig classification = resource.applicationType;
if (attribute.equals(CONFIGURED_APPLICATION.getName())) {
Boolean confValue = readValue(context, value, CONFIGURED_APPLICATION);
classification.setConfiguredApplication(confValue);
} else {
//TODO i18n
throw new IllegalStateException();
}
classification.setConfiguredApplication(readValue(context, value, CONFIGURED_APPLICATION));

context.completeStep(new OperationContext.RollbackHandler() {

0 comments on commit 14a2e5a

Please sign in to comment.
You can’t perform that action at this time.