Skip to content
Permalink
Browse files

Merge pull request #3753 from wildfly/revert-2935-WFCORE-3185

Revert "[WFCORE-3185] Run parallel boot tasks in coarser grained chunks"
  • Loading branch information
jmesnil committed Apr 24, 2019
2 parents 5c3777b + 72744f1 commit d282885037eac0050b576cd833e822beaca107e3
@@ -334,10 +334,7 @@ public void start(final StartContext context) throws StartException {
rootResourceRegistration,
new ContainerStateMonitor(container, getStabilityMonitor()),
configurationPersister, processType, runningModeControl, prepareStep,
processState, executorService,
getMaxParallelBootExtensionTasks(),
getMaxParallelBootSubsystemTasks(),
expressionResolver, authorizer, securityIdentitySupplier, auditLogger, notificationSupport,
processState, executorService, expressionResolver, authorizer, securityIdentitySupplier, auditLogger, notificationSupport,
bootErrorCollector, createExtraValidationStepHandler(), capabilityRegistry, getPartialModelIndicator(),
injectedInstabilityListener.getOptionalValue());

@@ -398,14 +395,6 @@ public ServiceTarget getServiceTarget() {
bootThread.start();
}

protected int getMaxParallelBootExtensionTasks() {
return 1;
}

protected int getMaxParallelBootSubsystemTasks() {
return 1;
}

/**
* Gets whether this controller service should install a {@link ModelControllerClientFactory}
* and a {@link org.jboss.as.controller.notification.NotificationHandlerRegistry}
@@ -125,8 +125,6 @@
private final OperationStepHandler prepareStep;
private final ControlledProcessState processState;
private final ExecutorService executorService;
private final int maxParallelBootExtensionTasks;
private final int maxParallelBootSubsystemTasks;
private final ExpressionResolver expressionResolver;
private final Authorizer authorizer;
private final Supplier<SecurityIdentity> securityIdentitySupplier;
@@ -155,8 +153,6 @@
final ContainerStateMonitor stateMonitor, final ConfigurationPersister persister,
final ProcessType processType, final RunningModeControl runningModeControl,
final OperationStepHandler prepareStep, final ControlledProcessState processState, final ExecutorService executorService,
final int maxParallelBootExtensionTasks,
final int maxParallelBootSubsystemTasks,
final ExpressionResolver expressionResolver, final Authorizer authorizer, final Supplier<SecurityIdentity> securityIdentitySupplier,
final ManagedAuditLogger auditLogger, NotificationSupport notificationSupport,
final BootErrorCollector bootErrorCollector, final OperationStepHandler extraValidationStepHandler,
@@ -190,8 +186,6 @@
this.processState = processState;
this.serviceTarget.addMonitor(stateMonitor.getStabilityMonitor());
this.executorService = executorService;
this.maxParallelBootExtensionTasks = maxParallelBootExtensionTasks;
this.maxParallelBootSubsystemTasks = maxParallelBootSubsystemTasks;
assert expressionResolver != null;
this.expressionResolver = expressionResolver;
assert securityIdentitySupplier != null;
@@ -606,10 +600,9 @@ private BootOperations organizeBootOperations(List<ModelNode> bootList, final in
final ManagementResourceRegistration rootRegistration = managementModel.get().getRootResourceRegistration();
final MutableRootResourceRegistrationProvider parallellBRRRProvider = parallelBootRootResourceRegistrationProvider != null ?
parallelBootRootResourceRegistrationProvider : getMutableRootResourceRegistrationProvider();
ParallelExtensionAddHandler parallelExtensionAddHandler = executorService == null || maxParallelBootExtensionTasks < 2 ? null : new ParallelExtensionAddHandler(executorService, maxParallelBootExtensionTasks, parallellBRRRProvider);
ParallelBootOperationStepHandler parallelSubsystemHandler = (executorService != null && maxParallelBootSubsystemTasks > 1 && processType.isServer() && runningModeControl.getRunningMode() == RunningMode.NORMAL)
? new ParallelBootOperationStepHandler(executorService, maxParallelBootSubsystemTasks, rootRegistration, processState, this, lockPermit, extraValidationStepHandler)
: null;
ParallelExtensionAddHandler parallelExtensionAddHandler = executorService == null ? null : new ParallelExtensionAddHandler(executorService, parallellBRRRProvider);
ParallelBootOperationStepHandler parallelSubsystemHandler = (executorService != null && processType.isServer() && runningModeControl.getRunningMode() == RunningMode.NORMAL)
? new ParallelBootOperationStepHandler(executorService, rootRegistration, processState, this, lockPermit, extraValidationStepHandler) : null;
boolean registeredParallelSubsystemHandler = false;
int subsystemIndex = 0;
for (ModelNode bootOp : bootList) {

0 comments on commit d282885

Please sign in to comment.
You can’t perform that action at this time.